Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 873963002: Enable text-align-last property, by default. (Closed)

Created:
5 years, 11 months ago by dw.im
Modified:
5 years, 3 months ago
CC:
kojii
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Enable text-align-last property, by default. text-align-last is the CSS property which can affect to the last line of a block, even if it is also first line of it. http://www.w3.org/TR/css-text-3/#text-align-last-property Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=202655

Patch Set 1 #

Patch Set 2 : patch for landing #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -14 lines) Patch
M LayoutTests/virtual/stable/webexposed/css-properties-as-js-properties-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/virtual/stable/webexposed/nonstable-css-properties-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/webexposed/nonstable-css-properties.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/webexposed/nonstable-css-properties-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/css/CSSProperties.in View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/parser/CSSParserFastPaths.cpp View 1 chunk +0 lines, -1 line 0 comments Download
Source/core/layout/LayoutBlockFlowLine.cpp View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (3 generated)
dw.im
Got lgtm from Jochen, Chris, and Philip to the 'Intent to ship'. So I guess ...
5 years, 10 months ago (2015-01-27 10:56:25 UTC) #2
dw.im
5 years, 10 months ago (2015-01-27 11:15:06 UTC) #3
eae
Normally we just change the runtime feature to stable and wait for a release or ...
5 years, 10 months ago (2015-01-27 14:59:16 UTC) #4
leviw_travelin_and_unemployed
eae is right. You also need to correct the results for these tests: virtual/stable/webexposed/css-properties-as-js-properties.html virtual/stable/webexposed/nonstable-css-properties.html
5 years, 10 months ago (2015-01-27 15:30:52 UTC) #5
dw.im
On 2015/01/27 14:59:16, eae wrote: > Normally we just change the runtime feature to stable ...
5 years, 10 months ago (2015-01-28 01:41:01 UTC) #6
dw.im
On 2015/01/27 15:30:52, leviw wrote: > eae is right. You also need to correct the ...
5 years, 10 months ago (2015-01-28 01:41:36 UTC) #7
ebraminio
Any news here?
5 years, 9 months ago (2015-03-26 01:13:53 UTC) #8
leviw_travelin_and_unemployed
FWIW: dwim asked me to take a look at this and I have no issue ...
5 years, 3 months ago (2015-09-21 19:49:42 UTC) #10
dw.im
On 2015/09/21 19:49:42, leviw (UTCplus1 until 9-17) wrote: > FWIW: dwim asked me to take ...
5 years, 3 months ago (2015-09-22 10:25:54 UTC) #11
leviw_travelin_and_unemployed
lgtm
5 years, 3 months ago (2015-09-22 17:04:28 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/873963002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/873963002/80001
5 years, 3 months ago (2015-09-23 01:04:40 UTC) #14
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 01:11:24 UTC) #15
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=202655

Powered by Google App Engine
This is Rietveld 408576698