Issue 873943002: Disable {virtual,override,final} checks for Ozone CrOS builds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 873943002: Disable {virtual,override,final} checks for Ozone CrOS builds. (Closed)

Created:
5 years, 11 months ago by dcheng

Modified:
5 years, 11 months ago

Reviewers:
scottmg

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Disable {virtual,override,final} checks for Ozone CrOS builds. BUG=417463 TBR=scottmg@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/ee3ee89fd6d1b4d2858015fc0c2171f7fceaea1c

Patch Set 1 #

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	build/common.gypi	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

Patchset 1 (id:??) landed as https://crrev.com/ee3ee89fd6d1b4d2858015fc0c2171f7fceaea1c Cr-Commit-Position: refs/heads/master@{#313006}

5 years, 11 months ago (2015-01-24 03:51:51 UTC) #1

dcheng

Committed patchset #1 (id:1) manually as ee3ee89fd6d1b4d2858015fc0c2171f7fceaea1c.

5 years, 11 months ago (2015-01-24 03:52:01 UTC) #2

scottmg

The title seems to imply you might want and instead of or? But lgtm if ...

5 years, 11 months ago (2015-01-25 19:31:41 UTC) #3

dcheng

5 years, 11 months ago (2015-01-25 19:33:06 UTC) #4

Message was sent while issue was closed.

On 2015/01/25 at 19:31:41, scottmg wrote:
> The title seems to imply you might want and instead of or? But lgtm if it's
doing what you want.

I guess it would have been more clearly expressed as:
OS=="linux" and not (chromeos==1 and use_ozone==1)

But I wasn't 100% sure without some testing that this would do what I want, and
the tree was broken.

Expand Messages | Collapse Messages