Add <extensionview>

extensions/renderer/resources/guest_view/extension_view.js

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+// This module implements the ExtensionView <extensionview>.
+
+var GuestViewContainer = require('guestViewContainer').GuestViewContainer;
+var ExtensionViewConstants =
+    require('extensionViewConstants').ExtensionViewConstants;
+var ExtensionViewInternal =
+    require('extensionViewInternal').ExtensionViewInternal;
+
+function ExtensionViewImpl(extensionviewElement) {
+  GuestViewContainer.call(this, extensionviewElement, 'extensionview');
+  this.beforeFirstNavigation = true;

[Fady Samuel, 2015/01/27 22:59:57]

Move beforeFirstNavigation into SrcAttribute, then add a reset() method to reset
the beforeFirstNavigation.

[apacible, 2015/01/28 02:43:31]

Done.

+  this.setupExtensionViewAttributes();
+}
+
+ExtensionViewImpl.prototype.__proto__ = GuestViewContainer.prototype;
+
+ExtensionViewImpl.VIEW_TYPE = 'ExtensionView';
+
+ExtensionViewImpl.setupElement = function(proto) {
+  var apiMethods = [
+    'navigate'
+  ];
+
+  GuestViewContainer.forwardApiMethods(proto, apiMethods);
+};
+
+ExtensionViewImpl.prototype.createGuest = function() {
+  this.guest.create(this.buildParams(), function() {
+    this.attachWindow();
+  }.bind(this));
+};
+
+ExtensionViewImpl.prototype.onElementAttached = function() {
+  this.attributes[ExtensionViewConstants.ATTRIBUTE_SRC].parse();
+};
+
+ExtensionViewImpl.prototype.buildContainerParams = function() {
+  var params = {};
+  for (var i in this.attributes) {
+    params[i] = this.attributes[i].getValue();
+  }
+  return params;
+};
+
+// This observer monitors mutations to attributes of the <extensionview>.
+ExtensionViewImpl.prototype.handleAttributeMutation = function(
+    attributeName, oldValue, newValue) {
+  if (!this.attributes[attributeName])
+    return;
+
+  // Let the changed attribute handle its own mutation;
+  this.attributes[attributeName].handleMutation(oldValue, newValue);
+};
+
+ExtensionViewImpl.prototype.onElementDetached = function() {
+  this.guest.destroy();
+  this.beforeFirstNavigation = true;

[Fady Samuel, 2015/01/27 22:59:57]

Once you introduce a reset():

this.attributes[ExtensionViewConstants.ATTRIBUTE_SRC].reset(); here.

beforeFirstNavigation is kind of an implementation detail of SrcAttribute that
should go away from here. This needs to be fixed in WebView too. I'll take care
of that in WebView.

[apacible, 2015/01/28 02:43:31]

Done.

+};
+
+GuestViewContainer.registerElement(ExtensionViewImpl);
+
+// Exports.
+exports.ExtensionViewImpl = ExtensionViewImpl;