Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 873913002: Revert of Disable Mojo on RenderThreadImplBrowserTest on Android (Closed)

Created:
5 years, 11 months ago by Hajime Morrita
Modified:
5 years, 11 months ago
Reviewers:
Jay Civelli, sky
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Disable Mojo on RenderThreadImplBrowserTest on Android (patchset #1 id:1 of https://codereview.chromium.org/866973004/) Reason for revert: This doesn't work in some tests. Original issue's description: > Disable Mojo on RenderThreadImplBrowserTest on Android > > It hasn't worked from the beginning and it blocks ChannelMojo from > being enabled. > > BUG=451221 > R=jcivelli@chromium.org, sky@chromium.org > > Committed: https://crrev.com/b5a99f2c1652471236c5d07403faa42bf53420df > Cr-Commit-Position: refs/heads/master@{#312875} TBR=jcivelli@chromium.org,sky@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=451221 Committed: https://crrev.com/2f16a8e145ce89fd744cfbb4be4eee235cfbc1c9 Cr-Commit-Position: refs/heads/master@{#312988}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -12 lines) Patch
M content/test/render_thread_impl_browser_test_ipc_helper.cc View 1 chunk +1 line, -12 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Hajime Morrita
Created Revert of Disable Mojo on RenderThreadImplBrowserTest on Android
5 years, 11 months ago (2015-01-24 01:31:53 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/873913002/1
5 years, 11 months ago (2015-01-24 01:33:17 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-24 01:34:14 UTC) #3
commit-bot: I haz the power
5 years, 11 months ago (2015-01-24 01:35:19 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2f16a8e145ce89fd744cfbb4be4eee235cfbc1c9
Cr-Commit-Position: refs/heads/master@{#312988}

Powered by Google App Engine
This is Rietveld 408576698