Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: extensions/browser/api/serial/serial_connection.h

Issue 873903002: Set serial connection parameters immediately on connect. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add a comment explaing the "set" notation. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/browser/api/serial/serial_api.cc ('k') | extensions/browser/api/serial/serial_connection.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/api/serial/serial_connection.h
diff --git a/extensions/browser/api/serial/serial_connection.h b/extensions/browser/api/serial/serial_connection.h
index cb698efa75f5eef3420591a8fda9ffa1ea2ba353..7fc553590007e825dabf9d9a6092784f55d7c837 100644
--- a/extensions/browser/api/serial/serial_connection.h
+++ b/extensions/browser/api/serial/serial_connection.h
@@ -73,7 +73,8 @@ class SerialConnection : public ApiResource,
// Initiates an asynchronous Open of the device. It is the caller's
// responsibility to ensure that this SerialConnection stays alive
// until |callback| is run.
- void Open(const OpenCompleteCallback& callback);
+ void Open(const core_api::serial::ConnectionOptions& options,
+ const OpenCompleteCallback& callback);
// Begins an asynchronous receive operation. Calling this while a Receive
// is already pending is a no-op and returns |false| without calling
« no previous file with comments | « extensions/browser/api/serial/serial_api.cc ('k') | extensions/browser/api/serial/serial_connection.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698