extensions/browser/api/serial/serial_api.cc - Issue 873903002: Set serial connection parameters immediately on connect.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/serial/serial_api.cc

Issue 873903002: Set serial connection parameters immediately on connect. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « device/serial/test_serial_io_handler.cc ('k') | extensions/browser/api/serial/serial_connection.h » ('j') | extensions/renderer/api/serial/serial_api_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/serial/serial_api.cc

diff --git a/extensions/browser/api/serial/serial_api.cc b/extensions/browser/api/serial/serial_api.cc

index 8910cc757a658b63b16ae9aaafe890b1d24128e5..d2eead810a58b0a7c21a6925c21aeb3777cc423c 100644

--- a/extensions/browser/api/serial/serial_api.cc

+++ b/extensions/browser/api/serial/serial_api.cc

@@ -130,18 +130,14 @@ bool SerialConnectFunction::Prepare() {

void SerialConnectFunction::AsyncWorkStart() {

DCHECK_CURRENTLY_ON(BrowserThread::IO);

connection_ = CreateSerialConnection(params_->path, extension_->id());

- connection_->Open(base::Bind(&SerialConnectFunction::OnConnected, this));

+ connection_->Open(*params_->options.get(),

+ base::Bind(&SerialConnectFunction::OnConnected, this));

}

void SerialConnectFunction::OnConnected(bool success) {

DCHECK(connection_);

- if (success) {

- if (!connection_->Configure(*params_->options.get())) {

- delete connection_;

- connection_ = NULL;

- }

- } else {

+ if (!success) {

delete connection_;

connection_ = NULL;

}