device/serial/serial_service_unittest.cc - Issue 873903002: Set serial connection parameters immediately on connect.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/serial/serial_service_unittest.cc

Issue 873903002: Set serial connection parameters immediately on connect. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « device/serial/serial_io_handler_win.cc ('k') | device/serial/test_serial_io_handler.h » ('j') | extensions/renderer/api/serial/serial_api_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: device/serial/serial_service_unittest.cc

diff --git a/device/serial/serial_service_unittest.cc b/device/serial/serial_service_unittest.cc

index bf0821777e53504d3f5e76966a9fd83970ffa88b..7f8beb23b5f59a73ef056d76ad12e041b123600e 100644

--- a/device/serial/serial_service_unittest.cc

+++ b/device/serial/serial_service_unittest.cc

@@ -28,6 +28,7 @@ class FakeSerialDeviceEnumerator : public SerialDeviceEnumerator {

class FailToOpenIoHandler : public TestSerialIoHandler {

public:

void Open(const std::string& port,

+ const serial::ConnectionOptions& options,

const OpenCompleteCallback& callback) override {

callback.Run(false);

}

« no previous file with comments | « device/serial/serial_io_handler_win.cc ('k') | device/serial/test_serial_io_handler.h » ('j') | extensions/renderer/api/serial/serial_api_unittest.cc » ('J')