device/serial/serial_io_handler_win.h - Issue 873903002: Set serial connection parameters immediately on connect.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/serial/serial_io_handler_win.h

Issue 873903002: Set serial connection parameters immediately on connect. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « device/serial/serial_io_handler_posix.cc ('k') | device/serial/serial_io_handler_win.cc » ('j') | extensions/renderer/api/serial/serial_api_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: device/serial/serial_io_handler_win.h

diff --git a/device/serial/serial_io_handler_win.h b/device/serial/serial_io_handler_win.h

index 6ffaea3d6dbb8e9c86d00a59b356ff4e9801ee27..6cdbedc0dee041c5399df12fb0b4b0a3e4afc69d 100644

--- a/device/serial/serial_io_handler_win.h

+++ b/device/serial/serial_io_handler_win.h

@@ -19,11 +19,11 @@ class SerialIoHandlerWin : public SerialIoHandler,

virtual void WriteImpl() override;

virtual void CancelReadImpl() override;

virtual void CancelWriteImpl() override;

+ virtual bool ConfigurePortImpl() override;

virtual bool Flush() const override;

virtual serial::DeviceControlSignalsPtr GetControlSignals() const override;

virtual bool SetControlSignals(

const serial::HostControlSignals& control_signals) override;

- virtual bool ConfigurePort(const serial::ConnectionOptions& options) override;

virtual serial::ConnectionInfoPtr GetPortInfo() const override;

virtual bool PostOpen() override;