Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Issue 873873002: kiosk: Close on the last window of kiosk app. (Closed)

Created:
5 years, 11 months ago by xiyuan
Modified:
5 years, 11 months ago
Reviewers:
bartfab (slow), jennyz
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org, bartfab (slow)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

kiosk: Close on the last window of kiosk app. Helper extension/app could have hidden windows created. Kiosk app session should only be bound with the kiosk app's window and not affected by them. BUG=449313 Committed: https://crrev.com/7538ed2a80a3ecbb66527957a2cf2a4af75e3e99 Cr-Commit-Position: refs/heads/master@{#312980}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M chrome/browser/chromeos/app_mode/app_session_lifetime.cc View 3 chunks +6 lines, -4 lines 2 comments Download

Messages

Total messages: 10 (3 generated)
xiyuan
5 years, 11 months ago (2015-01-23 23:57:34 UTC) #2
jennyz
lgtm
5 years, 11 months ago (2015-01-24 00:04:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/873873002/1
5 years, 11 months ago (2015-01-24 00:06:44 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-24 00:41:19 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/7538ed2a80a3ecbb66527957a2cf2a4af75e3e99 Cr-Commit-Position: refs/heads/master@{#312980}
5 years, 11 months ago (2015-01-24 00:42:16 UTC) #7
bartfab (slow)
What is a helper extension/app? How can there be more than one app active in ...
5 years, 11 months ago (2015-01-26 15:59:46 UTC) #9
xiyuan
5 years, 11 months ago (2015-01-26 17:21:32 UTC) #10
Message was sent while issue was closed.
When I saw the problem, the windows are hidden IME windows. It looks like we
changed the IME window from native code into an app and caused this regression.

We allow some helper apps such as file manager to be used in kiosk session now.
So only looking at the main kiosk app's window is more correct.

https://codereview.chromium.org/873873002/diff/1/chrome/browser/chromeos/app_...
File chrome/browser/chromeos/app_mode/app_session_lifetime.cc (right):

https://codereview.chromium.org/873873002/diff/1/chrome/browser/chromeos/app_...
chrome/browser/chromeos/app_mode/app_session_lifetime.cc:76: std::string
app_id_;
On 2015/01/26 15:59:46, bartfab wrote:
> Nit: const.

Cannot use const here because we use it as a AppWindowHandler and app is is set
via an Init call instead of constructor.

Powered by Google App Engine
This is Rietveld 408576698