Improve performance of addAll for internallt known lists.

runtime/lib/growable_array.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 class _GrowableList<T> extends ListBase<T> {
 
   void insert(int index, T element) {
     if ((index < 0) || (index > length)) {
       throw new RangeError.range(index, 0, length);
     }
@@ skipping 134 matching lines @@
     var len = length;
     if (len == _capacity) {
       _grow(len * 2);
     }
     _setLength(len + 1);
     this[len] = value;
   }
 
   void addAll(Iterable<T> iterable) {
     var len = length;
-    if (iterable is EfficientLength) {
+    final cid = ClassID.getID(iterable);
+    final isVMList =
+        (cid == ClassID.cidArray) ||
+        (cid == ClassID.cidGrowableObjectArray) ||
+        (cid == ClassID.cidImmutableArray);

[Lasse Reichstein Nielsen, 2015/01/27 15:13:57]

Would it be worth it to recognize growable list as well in setRange?

[srdjan, 2015/01/29 17:42:19]

I think so, but we would need to move it here since cid-s are VM specific stuff.
Comparing cids is faster than instanceof test.

+    if (isVMList || (iterable is EfficientLength)) {
       var cap = _capacity;
       // Pregrow if we know iterable.length.
       var iterLen = iterable.length;
       var newLen = len + iterLen;
       if (newLen > cap) {
         do {
           cap *= 2;
         } while (newLen > cap);
         _grow(cap);
       }
+      if (isVMList) {
+        if (identical(iterable, this)) {
+          throw new ConcurrentModificationError(this);

[Lasse Reichstein Nielsen, 2015/01/27 15:13:57]

This does change behavior (it now throws before adding the first element), but
nobody should be depending on that, so that's fine with me.

Of the internal lists, only GrowableObjectArray will reach here, the other ones
throw immediately when calling addAll, but the boolean is already computed, so
it's probably just as good as comparing cid to ClassID.cidGrowable....
Might be worth a comment though, so the _setLength below isn't confusing anyone
into thinking you change the length of an Array.

[srdjan, 2015/01/29 17:42:19]

I do not understand. 'this' is always GrowableObjectArray.

+        }
+        this._setLength(newLen);
+        for (int i = 0; i < iterLen; i++) {
+          this[len++] = iterable[i];
+        }
+        return;
+      }
     }
     Iterator it = iterable.iterator;
     if (!it.moveNext()) return;
     do {
       while (len < _capacity) {
         int newLen = len + 1;
         this._setLength(newLen);
         this[len] = it.current;
         if (!it.moveNext()) return;
         if (this.length != newLen) throw new ConcurrentModificationError(this);
@@ skipping 145 matching lines @@
       result._setLength(length);
       return result;
     }
     return growable ? <T>[] : new List<T>(0);
   }
 
   Set<T> toSet() {
     return new Set<T>.from(this);
   }
 }