Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 873853002: Fix a test for importing history. (Closed)

Created:
5 years, 11 months ago by mtomasz
Modified:
5 years, 11 months ago
Reviewers:
Steve McKay
CC:
chromium-reviews, tfarina, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix a test for importing history. The promise wasn't chained properly, and the condition was opposite. TEST=browser_tests: *ImportHistoryTest* BUG=None Committed: https://crrev.com/a7912902a29ae13884ed96fa4694025ab7598e79 Cr-Commit-Position: refs/heads/master@{#312961}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M ui/file_manager/file_manager/background/js/import_history_unittest.js View 1 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
mtomasz
@smckay: PTAL.
5 years, 11 months ago (2015-01-23 22:28:07 UTC) #2
Steve McKay
LGTM w/ nit. https://codereview.chromium.org/873853002/diff/1/ui/file_manager/file_manager/background/js/import_history_unittest.js File ui/file_manager/file_manager/background/js/import_history_unittest.js (right): https://codereview.chromium.org/873853002/diff/1/ui/file_manager/file_manager/background/js/import_history_unittest.js#newcode231 ui/file_manager/file_manager/background/js/import_history_unittest.js:231: return storage.write(['abc', '123']).then(function() { Inline anon ...
5 years, 11 months ago (2015-01-23 22:31:15 UTC) #3
mtomasz
https://codereview.chromium.org/873853002/diff/1/ui/file_manager/file_manager/background/js/import_history_unittest.js File ui/file_manager/file_manager/background/js/import_history_unittest.js (right): https://codereview.chromium.org/873853002/diff/1/ui/file_manager/file_manager/background/js/import_history_unittest.js#newcode231 ui/file_manager/file_manager/background/js/import_history_unittest.js:231: return storage.write(['abc', '123']).then(function() { On 2015/01/23 22:31:15, Steve McKay ...
5 years, 11 months ago (2015-01-23 22:37:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/873853002/20001
5 years, 11 months ago (2015-01-23 22:38:34 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-23 23:29:06 UTC) #7
commit-bot: I haz the power
5 years, 11 months ago (2015-01-23 23:30:15 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/a7912902a29ae13884ed96fa4694025ab7598e79
Cr-Commit-Position: refs/heads/master@{#312961}

Powered by Google App Engine
This is Rietveld 408576698