Issue 87383002: Fix autofill popup size

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 87383002: Fix autofill popup size (Closed)

Created:
7 years ago by jbauman

Modified:
7 years ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, sadrul, ben+views_chromium.org, ben+aura_chromium.org, tfarina, kalyank

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix autofill popup size This should tell the window its correct size, instead of the size expanded to be at least 64 pixels on each side. BUG=286609, 320974 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238284

Patch Set 1 #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -4 lines)			Patch
M	ui/aura/remote_root_window_host_win.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	ui/aura/remote_root_window_host_win.cc	View	2 chunks	+4 lines, -3 lines	0 comments	Download
M	ui/aura/root_window.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/views/widget/desktop_aura/desktop_root_window_host_win.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

jbauman

This is the same as https://codereview.chromium.org/69343016/ except with a fix to RemoteRootWindowHostWin::GetBounds.

7 years ago (2013-11-26 23:07:00 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbauman@chromium.org/87383002/1

7 years ago (2013-12-02 22:37:45 UTC) #3

commit-bot: I haz the power

Retried try job too often on mac_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=195623

7 years ago (2013-12-03 00:58:19 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbauman@chromium.org/87383002/1

7 years ago (2013-12-03 01:40:19 UTC) #5

Message was sent while issue was closed.

Change committed as 238284

Expand Messages | Collapse Messages