Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Issue 873823002: Address a warning about non-static classes. (Closed)

Created:
5 years, 11 months ago by sgurun-gerrit only
Modified:
5 years, 11 months ago
Reviewers:
hush (inactive)
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Address a warning about non-static classes. BUG=393291 Committed: https://crrev.com/5460c7107a1a80123dc1aa2ba32893a60a332f68 Cr-Commit-Position: refs/heads/master@{#312956}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -15 lines) Patch
M android_webview/java/src/org/chromium/android_webview/AwMessagePortService.java View 4 chunks +18 lines, -15 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
sgurun-gerrit only
PTAL, thanks,
5 years, 11 months ago (2015-01-23 21:37:06 UTC) #2
hush (inactive)
lgtm
5 years, 11 months ago (2015-01-23 22:03:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/873823002/1
5 years, 11 months ago (2015-01-23 22:04:49 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-23 22:55:36 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-23 22:56:32 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5460c7107a1a80123dc1aa2ba32893a60a332f68
Cr-Commit-Position: refs/heads/master@{#312956}

Powered by Google App Engine
This is Rietveld 408576698