Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(971)

Issue 873773002: Fix a broken dependency in generate_pnacl_support_extension (Closed)

Created:
5 years, 11 months ago by Sébastien Marchand
Modified:
5 years, 11 months ago
Reviewers:
bradnelson, bradn
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix a broken dependency in generate_pnacl_support_extension the '*_eh_a' outputs doesn't seem to be generated anymore, because of this you get the following log if you compile the pnacl_support_extension target twice: [master]E:\src\chrome\src>ninja -C out\Release pnacl_support_extension -d explain ninja: Entering directory `out\Release' ninja explain: output pnacl/pnacl_public_x86_32_libgcc_eh_a doesn't exist ninja explain: pnacl/pnacl_public_pnacl_json is dirty ninja explain: pnacl/pnacl_public_x86_32_crtbegin_o is dirty ninja explain: pnacl/pnacl_public_x86_32_ld_nexe is dirty ninja explain: pnacl/pnacl_public_x86_32_libcrt_platform_a is dirty ninja explain: pnacl/pnacl_public_x86_32_libgcc_a is dirty ninja explain: pnacl/pnacl_public_x86_32_libgcc_eh_a is dirty ninja explain: pnacl/pnacl_public_x86_32_libpnacl_irt_shim_a is dirty ninja explain: pnacl/pnacl_public_x86_32_pnacl_llc_nexe is dirty ninja explain: pnacl/pnacl_public_x86_64_crtbegin_o is dirty ninja explain: pnacl/pnacl_public_x86_64_ld_nexe is dirty ninja explain: pnacl/pnacl_public_x86_64_libcrt_platform_a is dirty ninja explain: pnacl/pnacl_public_x86_64_libgcc_a is dirty ninja explain: pnacl/pnacl_public_x86_64_libgcc_eh_a is dirty ninja explain: pnacl/pnacl_public_x86_64_libpnacl_irt_shim_a is dirty ninja explain: pnacl/pnacl_public_x86_64_pnacl_llc_nexe is dirty ninja explain: obj/ppapi/native_client/src/untrusted/pnacl_support_extension/pnacl_support_extension.actions_rules_copies.stamp is dirty [2/2] STAMP obj\ppapi\native_client\src\untrusted\pnacl_support_extension\pnacl_support_extension.actions_rules_copies.stamp BUG=439228 Committed: https://crrev.com/ed4c0454e327c0806f0102ef8edd4700eebf843e Cr-Commit-Position: refs/heads/master@{#312891}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M ppapi/native_client/src/untrusted/pnacl_support_extension/pnacl_support_extension.gyp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
Sébastien Marchand
PTAL.
5 years, 11 months ago (2015-01-23 18:14:48 UTC) #2
bradn
lgtm
5 years, 11 months ago (2015-01-23 18:20:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/873773002/1
5 years, 11 months ago (2015-01-23 18:21:51 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/37967) Try jobs failed on following ...
5 years, 11 months ago (2015-01-23 18:30:17 UTC) #8
bradnelson
lgtm
5 years, 11 months ago (2015-01-23 18:32:25 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/873773002/1
5 years, 11 months ago (2015-01-23 18:33:39 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/37967)
5 years, 11 months ago (2015-01-23 18:34:57 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/873773002/1
5 years, 11 months ago (2015-01-23 18:47:13 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-23 19:17:03 UTC) #16
commit-bot: I haz the power
5 years, 11 months ago (2015-01-23 19:18:03 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ed4c0454e327c0806f0102ef8edd4700eebf843e
Cr-Commit-Position: refs/heads/master@{#312891}

Powered by Google App Engine
This is Rietveld 408576698