Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Issue 873753002: Spin off GM::runAsBench() from flags. (Closed)

Created:
5 years, 11 months ago by mtklein_C
Modified:
5 years, 11 months ago
Reviewers:
bsalomon, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Spin off GM::runAsBench() from flags. This will let us kill flags. BUG=skia: Committed: https://skia.googlesource.com/skia/+/cf5d9c993dcbd75d4cefe2d1de25c2b9645f6957

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -9 lines) Patch
M bench/nanobench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/circularclips.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M gm/convexpolyclip.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M gm/dashing.cpp View 1 chunk +4 lines, -2 lines 0 comments Download
M gm/gm.h View 2 chunks +2 lines, -2 lines 0 comments Download
M gm/multipicturedraw.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M gm/variedtext.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
mtklein
5 years, 11 months ago (2015-01-23 17:11:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/873753002/1
5 years, 11 months ago (2015-01-23 17:11:41 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 11 months ago (2015-01-23 17:11:41 UTC) #5
bsalomon
On 2015/01/23 17:11:41, I haz the power (commit-bot) wrote: > Note for Reviewers: > The ...
5 years, 11 months ago (2015-01-23 18:31:25 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-23 18:31:48 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/cf5d9c993dcbd75d4cefe2d1de25c2b9645f6957

Powered by Google App Engine
This is Rietveld 408576698