Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 873723008: Wipe out isolate_ pointer after disposing it. (Closed)

Created:
5 years, 10 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 10 months ago
Reviewers:
dcarney
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Wipe out isolate_ pointer after disposing it. This is to rule out the (unlikely) case that we're sending idle notifications to a disposed isolate BUG=425035 R=dcarney@chromium.org Committed: https://crrev.com/5d4328ee3a31954c8cb424595becbdd62a359f11 Cr-Commit-Position: refs/heads/master@{#315041}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M gin/isolate_holder.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
jochen (gone - plz use gerrit)
5 years, 10 months ago (2015-02-06 15:01:15 UTC) #1
dcarney
lgtm
5 years, 10 months ago (2015-02-06 15:05:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/873723008/1
5 years, 10 months ago (2015-02-06 15:06:09 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-06 16:04:28 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-06 16:05:13 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5d4328ee3a31954c8cb424595becbdd62a359f11
Cr-Commit-Position: refs/heads/master@{#315041}

Powered by Google App Engine
This is Rietveld 408576698