DM::NullSink

DM::NullSink

Motivation:  The null sink can act as a control for experiments.

Committed: https://skia.googlesource.com/skia/+/022afb8384019b448c7c1c62a9ff63fa9e477737

[hal.canary, 2015-01-29 19:52:57]

The CQ bit was checked by halcanary@google.com

[commit-bot: I haz the power, 2015-01-29 19:53:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/873723007/1

[commit-bot: I haz the power, 2015-01-29 19:53:30]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2015-01-30 01:53 UTC

[mtklein, 2015-01-29 20:00:12]

mtklein@google.com changed reviewers:
+ mtklein@google.com

[mtklein, 2015-01-29 20:00:12]

https://codereview.chromium.org/873723007/diff/1/dm/DM.cpp
File dm/DM.cpp (right):

https://codereview.chromium.org/873723007/diff/1/dm/DM.cpp#newcode207
dm/DM.cpp:207: SINK("null",  NullSink);
Let's put this under if (FLAGS_cpu) { ... }.

https://codereview.chromium.org/873723007/diff/1/dm/DMSrcSink.h
File dm/DMSrcSink.h (right):

https://codereview.chromium.org/873723007/diff/1/dm/DMSrcSink.h#newcode182
dm/DMSrcSink.h:182: (void)out->writeText("0\n");
Is this so we don't try to encode an empty bitmap?

Sounds like we want the check to go from:

if (stream.len() > 0) {
  writeStream
} else {
  writeBitmap
}

to

if (stream.len() > 0) {
  writeStream
}
if (bitmap.sensible()) {
  writeBitmap
}

We don't really want to write any file for NullSink, do we?

https://codereview.chromium.org/873723007/diff/1/dm/DMSrcSink.h#newcode186
dm/DMSrcSink.h:186: const char* fileExtension() const SK_OVERRIDE { return
"null"; }
or even, ""?

[commit-bot: I haz the power, 2015-01-30 01:53:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-30 01:53:30]

No LGTM from a valid reviewer yet. Please ask for an LGTM from a
full Skia committer from
https://skia.googlesource.com/skia/+/master/CQ_COMMITTERS

[hal.canary, 2015-01-30 18:43:24]

https://codereview.chromium.org/873723007/diff/1/dm/DM.cpp
File dm/DM.cpp (right):

https://codereview.chromium.org/873723007/diff/1/dm/DM.cpp#newcode207
dm/DM.cpp:207: SINK("null",  NullSink);
On 2015/01/29 20:00:12, mtklein wrote:
> Let's put this under if (FLAGS_cpu) { ... }.

Done.

https://codereview.chromium.org/873723007/diff/1/dm/DMSrcSink.h
File dm/DMSrcSink.h (right):

https://codereview.chromium.org/873723007/diff/1/dm/DMSrcSink.h#newcode182
dm/DMSrcSink.h:182: (void)out->writeText("0\n");
On 2015/01/29 20:00:12, mtklein wrote:
> Is this so we don't try to encode an empty bitmap?
> 
> Sounds like we want the check to go from:
> 
> if (stream.len() > 0) {
>   writeStream
> } else {
>   writeBitmap
> }
> 
> to
> 
> if (stream.len() > 0) {
>   writeStream
> }
> if (bitmap.sensible()) {
>   writeBitmap
> }
> 
> We don't really want to write any file for NullSink, do we?

Done.

https://codereview.chromium.org/873723007/diff/1/dm/DMSrcSink.h#newcode186
dm/DMSrcSink.h:186: const char* fileExtension() const SK_OVERRIDE { return
"null"; }
On 2015/01/29 20:00:12, mtklein wrote:
> or even, ""?

Done.

[mtklein, 2015-01-30 18:53:13]

The CQ bit was checked by mtklein@google.com

[mtklein, 2015-01-30 18:53:14]

lgtm

[commit-bot: I haz the power, 2015-01-30 18:54:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/873723007/20001

[commit-bot: I haz the power, 2015-01-30 19:00:17]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/022afb8384019b448c7c1c62a9ff63fa9e477737