Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 873723005: Load API holder from prototype chain instead embedding it in handler. (Closed)

Created:
5 years, 10 months ago by ulan
Modified:
5 years, 10 months ago
Reviewers:
dcarney
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Load API holder from prototype chain instead embedding it in handler. BUG=v8:3629 LOG=N Committed: https://crrev.com/b98f27f5926042085ae09f3a0ab312367f623d58 Cr-Commit-Position: refs/heads/master@{#26331}

Patch Set 1 #

Patch Set 2 : Remove unused variable #

Patch Set 3 : More fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -24 lines) Patch
M src/ic/arm/handler-compiler-arm.cc View 1 1 chunk +9 lines, -3 lines 0 comments Download
M src/ic/arm64/handler-compiler-arm64.cc View 1 1 chunk +9 lines, -3 lines 0 comments Download
M src/ic/call-optimization.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/ic/call-optimization.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M src/ic/ia32/handler-compiler-ia32.cc View 1 chunk +9 lines, -3 lines 0 comments Download
M src/ic/mips/handler-compiler-mips.cc View 1 1 chunk +9 lines, -3 lines 0 comments Download
M src/ic/mips64/handler-compiler-mips64.cc View 1 2 1 chunk +9 lines, -3 lines 0 comments Download
M src/ic/x64/handler-compiler-x64.cc View 1 2 1 chunk +9 lines, -3 lines 0 comments Download
M src/ic/x87/handler-compiler-x87.cc View 1 1 chunk +9 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
ulan
PTAL
5 years, 10 months ago (2015-01-29 16:01:01 UTC) #2
dcarney
lgtm
5 years, 10 months ago (2015-01-29 16:03:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/873723005/40001
5 years, 10 months ago (2015-01-29 16:07:53 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-01-29 17:18:49 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-01-29 17:18:59 UTC) #7
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/b98f27f5926042085ae09f3a0ab312367f623d58
Cr-Commit-Position: refs/heads/master@{#26331}

Powered by Google App Engine
This is Rietveld 408576698