Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5086)

Unified Diff: chromeos/network/onc/onc_translator_shill_to_onc.cc

Issue 873713004: Introduce NetworkState::is_captive_portal() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Feedback, unit test Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromeos/network/network_state_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/network/onc/onc_translator_shill_to_onc.cc
diff --git a/chromeos/network/onc/onc_translator_shill_to_onc.cc b/chromeos/network/onc/onc_translator_shill_to_onc.cc
index f49742179ed6f3733c28194914e3e9d3f9e11e45..3de5f77ac946fca45e9509f3892bf8001f494986 100644
--- a/chromeos/network/onc/onc_translator_shill_to_onc.cc
+++ b/chromeos/network/onc/onc_translator_shill_to_onc.cc
@@ -434,8 +434,8 @@ void ShillToONCTranslator::TranslateNetworkWithState() {
}
onc_object_->SetStringWithoutPathExpansion(
::onc::network_config::kConnectionState, onc_state);
- // Only set 'RestrictedConnectivity' if true.
- if (state == shill::kStatePortal) {
+ // Only set 'RestrictedConnectivity' if captive portal state is true.
+ if (NetworkState::NetworkStateIsCaptivePortal(*shill_dictionary_)) {
onc_object_->SetBooleanWithoutPathExpansion(
::onc::network_config::kRestrictedConnectivity, true);
}
« no previous file with comments | « chromeos/network/network_state_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698