ui/file_manager/file_manager/foreground/js/ui/file_manager_ui.js - Issue 873703003: Update the visual design of Files.app's toolbar.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/file_manager/file_manager/foreground/js/ui/file_manager_ui.js

Issue 873703003: Update the visual design of Files.app's toolbar. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address review comments. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/file_manager/file_manager/foreground/js/ui/file_manager_ui.js

diff --git a/ui/file_manager/file_manager/foreground/js/ui/file_manager_ui.js b/ui/file_manager/file_manager/foreground/js/ui/file_manager_ui.js

index 6fb84305f8122e1911c9823ac2909b723f3238c6..09596205e52e1fcd224ba938f5f3c8a6a1b57ccd 100644

--- a/ui/file_manager/file_manager/foreground/js/ui/file_manager_ui.js

+++ b/ui/file_manager/file_manager/foreground/js/ui/file_manager_ui.js

@@ -351,15 +351,14 @@ FileManagerUI.prototype.relayout = function() {

FileManagerUI.prototype.setCurrentListType = function(listType) {

this.listContainer.setCurrentListType(listType);

+ var iconElement = queryRequiredElement(this.toggleViewButton, 'core-icon');

switch (listType) {

case ListContainer.ListType.DETAIL:

- this.toggleViewButton.classList.remove('table');

- this.toggleViewButton.classList.add('grid');

+ iconElement.icon = 'view-module';

break;

case ListContainer.ListType.THUMBNAIL:

- this.toggleViewButton.classList.remove('grid');

- this.toggleViewButton.classList.add('table');

+ iconElement.icon = 'view-list';

break;

default: