Add the ability to delete patchsets.

Add the ability to delete patchsets.

There's now a little trash can icon you can click which shows an inline
confirmation dialog to delete the patchet. Just like the old UI you
cannot delete the last patchset. This is enforced on the client, but
not on the server and if you did delete the last one the server then
won't even load the issue anymore.

I also made the buttons 30px tall instead of 29 so they can center
properly. Finally I renamed the edit-title-dialog to just the
edit dialog since it does more than just edit the title now.

R=ojan@chromium.org,agable@chromium.org

Committed: https://chromium.googlesource.com/infra/infra/+/7e2fa6d6b6f0f9f93d7e4427567f4dfd332645a5

[ojan, 2015-02-02 06:23:39]

lgtm

https://codereview.chromium.org/873593007/diff/20001/appengine/chromium_rietv...
File
appengine/chromium_rietveld/new_static/components/cr-patchset-edit-dialog.html
(right):

https://codereview.chromium.org/873593007/diff/20001/appengine/chromium_rietv...
appengine/chromium_rietveld/new_static/components/cr-patchset-edit-dialog.html:34:
margin-left: -1px;
Negative margins!

https://codereview.chromium.org/873593007/diff/20001/appengine/chromium_rietv...
appengine/chromium_rietveld/new_static/components/cr-patchset-edit-dialog.html:96:
this.sending = true;
Is this.sending read anywhere? Maybe outside the component?

https://codereview.chromium.org/873593007/diff/20001/appengine/chromium_rietv...
appengine/chromium_rietveld/new_static/components/cr-patchset-edit-dialog.html:96:
this.sending = true;
Is this.sending read anywhere? Maybe outside the component?

https://codereview.chromium.org/873593007/diff/20001/appengine/chromium_rietv...
File appengine/chromium_rietveld/new_static/components/cr-patchset-header.html
(right):

https://codereview.chromium.org/873593007/diff/20001/appengine/chromium_rietv...
appengine/chromium_rietveld/new_static/components/cr-patchset-header.html:79:
var dialogs = document.querySelector("html /deep/ cr-issue::shadow #dialogs");
ewww

[esprehn, 2015-02-02 06:28:52]

https://codereview.chromium.org/873593007/diff/20001/appengine/chromium_rietv...
File
appengine/chromium_rietveld/new_static/components/cr-patchset-edit-dialog.html
(right):

https://codereview.chromium.org/873593007/diff/20001/appengine/chromium_rietv...
appengine/chromium_rietveld/new_static/components/cr-patchset-edit-dialog.html:34:
margin-left: -1px;
On 2015/02/02 06:23:39, ojan wrote:
> Negative margins!

Yeah I want the borders to overlap with the trash can icon. :/

https://codereview.chromium.org/873593007/diff/20001/appengine/chromium_rietv...
appengine/chromium_rietveld/new_static/components/cr-patchset-edit-dialog.html:96:
this.sending = true;
On 2015/02/02 06:23:39, ojan wrote:
> Is this.sending read anywhere? Maybe outside the component?

That's a bug, in the template it does disabled?="{{ disabled }}" it should be
sending.

https://codereview.chromium.org/873593007/diff/20001/appengine/chromium_rietv...
File appengine/chromium_rietveld/new_static/components/cr-patchset-header.html
(right):

https://codereview.chromium.org/873593007/diff/20001/appengine/chromium_rietv...
appengine/chromium_rietveld/new_static/components/cr-patchset-header.html:79:
var dialogs = document.querySelector("html /deep/ cr-issue::shadow #dialogs");
On 2015/02/02 at 06:23:39, ojan wrote:
> ewww

Yeah this is super gross. I need to switch to a different way to dealing with
the data model. Having it all be top down and using this event to reload the
entire page isn't working. I probably also want some kind of dialog controller.

[esprehn, 2015-02-02 06:30:21]

The CQ bit was checked by esprehn@chromium.org

[commit-bot: I haz the power, 2015-02-02 06:30:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/873593007/40001

[commit-bot: I haz the power, 2015-02-02 06:34:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-02 06:34:45]

Try jobs failed on following builders:
  infra_tester on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/infra_tester/bu...)

[esprehn, 2015-02-02 06:40:55]

The CQ bit was checked by esprehn@chromium.org

[commit-bot: I haz the power, 2015-02-02 06:41:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/873593007/40001

[commit-bot: I haz the power, 2015-02-02 06:43:50]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/infra/infra/+/7e2fa6d6b6f0f9f93d7e4427567f4...