Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 873593006: [Cronet] Rename UploadTestServer.java to NativeTestServer.java (Closed)

Created:
5 years, 10 months ago by xunjieli
Modified:
5 years, 10 months ago
Reviewers:
pauljensen, mef, mmenke
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Cronet] Rename UploadTestServer.java to NativeTestServer.java UploadTestServer was originally intended for testing uploads. This CL renames it to NativeTestServer, since it has been used as a general test server. BUG=452643 Committed: https://crrev.com/6a60c77553e1bfe0f51514242eeeae6bdf87f27e Cr-Commit-Position: refs/heads/master@{#313996}

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -141 lines) Patch
M components/cronet.gypi View 1 chunk +1 line, -1 line 0 comments Download
M components/cronet/android/test/cronet_test_jni.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/cronet/android/test/javatests/src/org/chromium/cronet_test_apk/CronetUrlRequestContextTest.java View 7 chunks +12 lines, -12 lines 0 comments Download
M components/cronet/android/test/javatests/src/org/chromium/cronet_test_apk/CronetUrlRequestTest.java View 8 chunks +11 lines, -11 lines 0 comments Download
M components/cronet/android/test/javatests/src/org/chromium/cronet_test_apk/UploadTest.java View 11 chunks +11 lines, -11 lines 0 comments Download
M components/cronet/android/test/javatests/src/org/chromium/cronet_test_apk/urlconnection/CronetHttpURLConnectionTest.java View 25 chunks +30 lines, -30 lines 0 comments Download
M components/cronet/android/test/javatests/src/org/chromium/cronet_test_apk/urlconnection/CronetHttpURLStreamHandlerTest.java View 1 3 chunks +5 lines, -5 lines 0 comments Download
A + components/cronet/android/test/src/org/chromium/cronet_test_apk/NativeTestServer.java View 2 chunks +7 lines, -7 lines 0 comments Download
D components/cronet/android/test/src/org/chromium/cronet_test_apk/UploadTestServer.java View 1 chunk +0 lines, -58 lines 0 comments Download
M components/cronet/android/test/upload_test_server.h View 1 chunk +1 line, -1 line 0 comments Download
M components/cronet/android/test/upload_test_server.cc View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
xunjieli
5 years, 10 months ago (2015-01-29 18:03:56 UTC) #2
mmenke
LGTM.
5 years, 10 months ago (2015-01-30 15:23:48 UTC) #3
mef
lgtm
5 years, 10 months ago (2015-01-30 15:56:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/873593006/20001
5 years, 10 months ago (2015-01-30 20:48:17 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-01-30 21:40:50 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-01-30 21:41:41 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6a60c77553e1bfe0f51514242eeeae6bdf87f27e
Cr-Commit-Position: refs/heads/master@{#313996}

Powered by Google App Engine
This is Rietveld 408576698