Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Issue 873583004: Revert of Remove the use of page id from NavController's GetVisibleEntry. (Closed)

Created:
5 years, 11 months ago by kochi
Modified:
5 years, 11 months ago
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove the use of page id from NavController's GetVisibleEntry. (patchset #2 id:20001 of https://codereview.chromium.org/850953002/) Reason for revert: The series of changes (r312793, r312792, r312791) are suspected to break pushState() related layout tests in Blink. Might be some of them only affected, but let me revert all of them. BUG=451351 Original issue's description: > Remove the use of page id from NavController's GetVisibleEntry. > > BUG=369661 > TEST=tests stay green > > Committed: https://crrev.com/6b988de501639cc9a8f9d40aa25fc44b431de71d > Cr-Commit-Position: refs/heads/master@{#312792} TBR=creis@chromium.org,avi@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=369661 Committed: https://crrev.com/67d33496116a22ce2244977569314d818525da04 Cr-Commit-Position: refs/heads/master@{#312802}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M content/browser/frame_host/navigation_controller_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
kochi
Created Revert of Remove the use of page id from NavController's GetVisibleEntry.
5 years, 11 months ago (2015-01-23 09:28:47 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/873583004/1
5 years, 11 months ago (2015-01-23 09:29:16 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-23 09:30:07 UTC) #3
commit-bot: I haz the power
5 years, 11 months ago (2015-01-23 09:31:01 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/67d33496116a22ce2244977569314d818525da04
Cr-Commit-Position: refs/heads/master@{#312802}

Powered by Google App Engine
This is Rietveld 408576698