Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 873583003: Revert of Call directly to c callbacks in Invoke instead of transitioning to js and back out. (Closed)

Created:
5 years, 11 months ago by dcarney
Modified:
5 years, 11 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Call directly to c callbacks in Invoke instead of transitioning to js and back out. (patchset #9 id:150001 of https://codereview.chromium.org/864273002/) Reason for revert: threading4 flakiness Original issue's description: > Call directly to c callbacks in Invoke instead of transitioning to js and back out. > > BUG= > > Committed: https://crrev.com/ce457e2b596c3ccf5bf454eeed0969f3f3efd174 > Cr-Commit-Position: refs/heads/master@{#26231} TBR=verwaest@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/5d14e4bcffea6c6c78ccc7815697444e3103279a Cr-Commit-Position: refs/heads/master@{#26236}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -87 lines) Patch
M src/builtins.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/builtins.cc View 4 chunks +21 lines, -63 lines 0 comments Download
M src/execution.cc View 1 chunk +0 lines, -20 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
dcarney
Created Revert of Call directly to c callbacks in Invoke instead of transitioning to js ...
5 years, 11 months ago (2015-01-23 08:53:12 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/873583003/1
5 years, 11 months ago (2015-01-23 08:54:08 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-23 08:54:23 UTC) #3
commit-bot: I haz the power
5 years, 11 months ago (2015-01-23 08:54:34 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5d14e4bcffea6c6c78ccc7815697444e3103279a
Cr-Commit-Position: refs/heads/master@{#26236}

Powered by Google App Engine
This is Rietveld 408576698