|
|
DescriptionUpdating usrsctp in DEPS to rev 9166.
BUG=
Committed: https://crrev.com/59ed552cd82a2e827f673241bae8a45edc76e0df
Cr-Commit-Position: refs/heads/master@{#317437}
Patch Set 1 #Patch Set 2 : Update libusrsctp to rev 9167 #Messages
Total messages: 30 (13 generated)
lally@chromium.org changed reviewers: + juberti@chromium.org, pthatcher@chromium.org
pthatcher@webrtc.org changed reviewers: + pthatcher@webrtc.org
lgtm
The CQ bit was checked by lally@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/873553004/20001
The CQ bit was unchecked by commit-bot@chromium.org
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an LGTM may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
lally@google.com changed reviewers: + lally@google.com
On 2015/02/20 18:38:15, I haz the power (commit-bot) wrote: > No LGTM from a valid reviewer yet. Only full committers are accepted. > Even if an LGTM may have been provided, it was from a non-committer, > _not_ a full super star committer. > See http://www.chromium.org/getting-involved/become-a-committer > Note that this has nothing to do with OWNERS files. lgtm
The CQ bit was checked by lally@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/873553004/20001
The CQ bit was unchecked by commit-bot@chromium.org
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an LGTM may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
Ping -- anyone mind lgtm'ing from a committer account? Cheers, $ ls Lally Singh | Google Ideas <http://www.google.com/ideas/> | Engineering | lally@google.com On Fri, Feb 20, 2015 at 1:43 PM, <commit-bot@chromium.org> wrote: > No LGTM from a valid reviewer yet. Only full committers are accepted. > Even if an LGTM may have been provided, it was from a non-committer, > _not_ a full super star committer. > See http://www.chromium.org/getting-involved/become-a-committer > Note that this has nothing to do with OWNERS files. > > https://codereview.chromium.org/873553004/ > To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
juberti@chromium.org changed reviewers: + jiayl@chromium.org
On 2015/02/20 20:47:50, chromium-reviews wrote: > Ping -- anyone mind lgtm'ing from a committer account? > > > Cheers, > $ ls > > Lally Singh | Google Ideas <http://www.google.com/ideas/> | Engineering | > mailto:lally@google.com > > > On Fri, Feb 20, 2015 at 1:43 PM, <mailto:commit-bot@chromium.org> wrote: > > > No LGTM from a valid reviewer yet. Only full committers are accepted. > > Even if an LGTM may have been provided, it was from a non-committer, > > _not_ a full super star committer. > > See http://www.chromium.org/getting-involved/become-a-committer > > Note that this has nothing to do with OWNERS files. > > > > https://codereview.chromium.org/873553004/ > > > > To unsubscribe from this group and stop receiving emails from it, send an email > to mailto:chromium-reviews+unsubscribe@chromium.org. +jiayl who can commit Is there a reason hashes other than the usrsctp hash changed?
On 2015/02/20 21:41:26, juberti2 wrote: > On 2015/02/20 20:47:50, chromium-reviews wrote: > > Ping -- anyone mind lgtm'ing from a committer account? > > > > > > Cheers, > > $ ls > > > > Lally Singh | Google Ideas <http://www.google.com/ideas/> | Engineering | > > mailto:lally@google.com > > > > > > On Fri, Feb 20, 2015 at 1:43 PM, <mailto:commit-bot@chromium.org> wrote: > > > > > No LGTM from a valid reviewer yet. Only full committers are accepted. > > > Even if an LGTM may have been provided, it was from a non-committer, > > > _not_ a full super star committer. > > > See http://www.chromium.org/getting-involved/become-a-committer > > > Note that this has nothing to do with OWNERS files. > > > > > > https://codereview.chromium.org/873553004/ > > > > > > > To unsubscribe from this group and stop receiving emails from it, send an > email > > to mailto:chromium-reviews+unsubscribe@chromium.org. > > +jiayl who can commit > > Is there a reason hashes other than the usrsctp hash changed? The DEPS in Patch Set 2 is based on a newer DEPS than the one in Patch Set 1. The side-by-side diffs show just 1 line changing.
On 2015/02/20 21:44:04, Lally Singh wrote: > On 2015/02/20 21:41:26, juberti2 wrote: > > On 2015/02/20 20:47:50, chromium-reviews wrote: > > > Ping -- anyone mind lgtm'ing from a committer account? > > > > > > > > > Cheers, > > > $ ls > > > > > > Lally Singh | Google Ideas <http://www.google.com/ideas/> | Engineering | > > > mailto:lally@google.com > > > > > > > > > On Fri, Feb 20, 2015 at 1:43 PM, <mailto:commit-bot@chromium.org> wrote: > > > > > > > No LGTM from a valid reviewer yet. Only full committers are accepted. > > > > Even if an LGTM may have been provided, it was from a non-committer, > > > > _not_ a full super star committer. > > > > See http://www.chromium.org/getting-involved/become-a-committer > > > > Note that this has nothing to do with OWNERS files. > > > > > > > > https://codereview.chromium.org/873553004/ > > > > > > > > > > To unsubscribe from this group and stop receiving emails from it, send an > > email > > > to mailto:chromium-reviews+unsubscribe@chromium.org. > > > > +jiayl who can commit > > > > Is there a reason hashes other than the usrsctp hash changed? > > The DEPS in Patch Set 2 is based on a newer DEPS than the one in Patch Set 1. > The side-by-side diffs show just 1 line changing. You can land from the web UI by checking the "commit queue".
The CQ bit was checked by lally@google.com
On 2015/02/20 22:32:20, jiayl wrote: > On 2015/02/20 21:44:04, Lally Singh wrote: > > On 2015/02/20 21:41:26, juberti2 wrote: > > > On 2015/02/20 20:47:50, chromium-reviews wrote: > > > > Ping -- anyone mind lgtm'ing from a committer account? > > > > > > > > > > > > Cheers, > > > > $ ls > > > > > > > > Lally Singh | Google Ideas <http://www.google.com/ideas/> | Engineering | > > > > mailto:lally@google.com > > > > > > > > > > > > On Fri, Feb 20, 2015 at 1:43 PM, <mailto:commit-bot@chromium.org> wrote: > > > > > > > > > No LGTM from a valid reviewer yet. Only full committers are accepted. > > > > > Even if an LGTM may have been provided, it was from a non-committer, > > > > > _not_ a full super star committer. > > > > > See http://www.chromium.org/getting-involved/become-a-committer > > > > > Note that this has nothing to do with OWNERS files. > > > > > > > > > > https://codereview.chromium.org/873553004/ > > > > > > > > > > > > > To unsubscribe from this group and stop receiving emails from it, send an > > > email > > > > to mailto:chromium-reviews+unsubscribe@chromium.org. > > > > > > +jiayl who can commit > > > > > > Is there a reason hashes other than the usrsctp hash changed? > > > > The DEPS in Patch Set 2 is based on a newer DEPS than the one in Patch Set 1. > > The side-by-side diffs show just 1 line changing. > > You can land from the web UI by checking the "commit queue". That's what I did.
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/873553004/20001
The CQ bit was unchecked by commit-bot@chromium.org
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an LGTM may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
lgtm
The CQ bit was checked by jiayl@chromium.org
The CQ bit was unchecked by lally@chromium.org
The CQ bit was checked by lally@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/873553004/20001
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/59ed552cd82a2e827f673241bae8a45edc76e0df Cr-Commit-Position: refs/heads/master@{#317437} |