Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 873533002: Cleanup WebViewRendererState (Closed)

Created:
5 years, 11 months ago by Fady Samuel
Modified:
5 years, 11 months ago
Reviewers:
lazyboy
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup WebViewRendererState Rename webview_ to web_view to be more consistent with naming elsewhere. Use auto when useful. BUG=none Committed: https://crrev.com/8a90168bcbe5883721abd5d7a6c87af34baa9332 Cr-Commit-Position: refs/heads/master@{#312928}

Patch Set 1 #

Patch Set 2 : Fixed compile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -30 lines) Patch
M extensions/browser/guest_view/web_view/web_view_renderer_state.h View 1 3 chunks +7 lines, -7 lines 0 comments Download
M extensions/browser/guest_view/web_view/web_view_renderer_state.cc View 1 3 chunks +22 lines, -23 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
Fady Samuel
5 years, 11 months ago (2015-01-22 23:00:48 UTC) #3
Fady Samuel
5 years, 11 months ago (2015-01-22 23:00:48 UTC) #4
lazyboy
lgtm
5 years, 11 months ago (2015-01-22 23:08:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/873533002/1
5 years, 11 months ago (2015-01-22 23:11:34 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/116977) linux_chromium_gn_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_dbg/builds/35479)
5 years, 11 months ago (2015-01-22 23:39:32 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/873533002/20001
5 years, 11 months ago (2015-01-23 20:24:38 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-23 21:12:35 UTC) #12
commit-bot: I haz the power
5 years, 11 months ago (2015-01-23 21:13:19 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8a90168bcbe5883721abd5d7a6c87af34baa9332
Cr-Commit-Position: refs/heads/master@{#312928}

Powered by Google App Engine
This is Rietveld 408576698