Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 873473008: Remove always true if statement and commented out code in GrBitmapTextContext (Closed)

Created:
5 years, 10 months ago by qiankun
Modified:
5 years, 10 months ago
Reviewers:
jvanverth1, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove always true if statement and commented out code in GrBitmapTextContext BUG=skia: Committed: https://skia.googlesource.com/skia/+/06fb35fe073f4bf213eb6a48498a1319bcff6cf2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -7 lines) Patch
M src/gpu/GrBitmapTextContext.cpp View 1 chunk +4 lines, -7 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
qiankun
Hi reed, please help to review this CL. What does "SkCLZ(3)" do here? I didn't ...
5 years, 10 months ago (2015-01-28 05:01:07 UTC) #2
qiankun1
On 2015/01/28 05:01:07, qiankun wrote: > Hi reed, please help to review this CL. What ...
5 years, 10 months ago (2015-01-29 14:57:22 UTC) #3
reed1
The "true" and "CLZ" removals seem fine. What happened to the NULL check on fPlot?
5 years, 10 months ago (2015-01-29 15:56:57 UTC) #5
qiankun1
On 2015/01/29 15:56:57, reed1 wrote: > The "true" and "CLZ" removals seem fine. What happened ...
5 years, 10 months ago (2015-01-29 16:20:49 UTC) #6
jvanverth1
On 2015/01/29 16:20:49, qiankun1 wrote: > On 2015/01/29 15:56:57, reed1 wrote: > > The "true" ...
5 years, 10 months ago (2015-01-29 16:38:20 UTC) #7
qiankun1
On 2015/01/29 16:38:20, jvanverth1 wrote: > On 2015/01/29 16:20:49, qiankun1 wrote: > > On 2015/01/29 ...
5 years, 10 months ago (2015-01-29 17:06:17 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/873473008/1
5 years, 10 months ago (2015-01-30 02:29:23 UTC) #10
commit-bot: I haz the power
5 years, 10 months ago (2015-01-30 02:36:56 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/06fb35fe073f4bf213eb6a48498a1319bcff6cf2

Powered by Google App Engine
This is Rietveld 408576698