Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Issue 873473006: cc: Commit directly to active tree when using single thread. (Closed)

Created:
5 years, 10 months ago by danakj
Modified:
5 years, 10 months ago
Reviewers:
vmpstr, enne (OOO)
CC:
cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Commit directly to active tree when using single thread. Skip making a pending tree, we'll want to wait for it anyways before we draw in single-thread mode. This should bring the single-thread impl-side painting in line with the legacy compositing mode when using a single thread (for the browser compositor). R=enne@chromium.org, vmpstr BUG=441012 Committed: https://crrev.com/009cdfdf4f51ff274e63344d9f42086f22aee799 Cr-Commit-Position: refs/heads/master@{#316678}

Patch Set 1 #

Total comments: 2

Patch Set 2 : committoactive: rebase #

Patch Set 3 : committoactive: testspass #

Patch Set 4 : committoactive: smallerdiff #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -33 lines) Patch
M cc/layers/texture_layer_unittest.cc View 1 2 1 chunk +1 line, -4 lines 0 comments Download
M cc/test/fake_proxy.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M cc/test/fake_proxy.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_host_impl.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 1 2 chunks +1 line, -7 lines 0 comments Download
M cc/trees/layer_tree_host_unittest.cc View 1 2 2 chunks +4 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_picture.cc View 1 2 4 chunks +6 lines, -4 lines 0 comments Download
M cc/trees/proxy.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M cc/trees/single_thread_proxy.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M cc/trees/single_thread_proxy.cc View 1 2 3 5 chunks +22 lines, -15 lines 0 comments Download
M cc/trees/thread_proxy.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M cc/trees/thread_proxy.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (3 generated)
danakj
Bots might be angry, or maybe not!
5 years, 10 months ago (2015-01-28 01:09:54 UTC) #1
enne (OOO)
https://codereview.chromium.org/873473006/diff/1/cc/trees/single_thread_proxy.cc File cc/trees/single_thread_proxy.cc (right): https://codereview.chromium.org/873473006/diff/1/cc/trees/single_thread_proxy.cc#newcode88 cc/trees/single_thread_proxy.cc:88: return false; ...false?!
5 years, 10 months ago (2015-01-28 01:14:53 UTC) #2
danakj
https://codereview.chromium.org/873473006/diff/1/cc/trees/single_thread_proxy.cc File cc/trees/single_thread_proxy.cc (right): https://codereview.chromium.org/873473006/diff/1/cc/trees/single_thread_proxy.cc#newcode88 cc/trees/single_thread_proxy.cc:88: return false; On 2015/01/28 01:14:53, enne_OOO_until_jan_26 wrote: > ...false?! ...
5 years, 10 months ago (2015-01-28 01:28:20 UTC) #3
danakj
ok i fixed up all the failing unit tests with commit to active. hopefully it's ...
5 years, 10 months ago (2015-02-17 19:50:38 UTC) #4
enne (OOO)
lgtm
5 years, 10 months ago (2015-02-17 20:28:37 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/873473006/60001
5 years, 10 months ago (2015-02-17 20:29:53 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_rel_tests_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_rel_tests_recipe/builds/2495)
5 years, 10 months ago (2015-02-17 21:36:31 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/873473006/60001
5 years, 10 months ago (2015-02-17 21:42:38 UTC) #11
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 10 months ago (2015-02-17 22:35:21 UTC) #12
commit-bot: I haz the power
5 years, 10 months ago (2015-02-17 22:36:43 UTC) #13
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/009cdfdf4f51ff274e63344d9f42086f22aee799
Cr-Commit-Position: refs/heads/master@{#316678}

Powered by Google App Engine
This is Rietveld 408576698