Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(560)

Unified Diff: shell/dynamic_application_loader_unittest.cc

Issue 873453004: Use ShellPtr type in ApplicationLoader instead of untyped handles (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: fix android Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « shell/dynamic_application_loader.cc ('k') | shell/external_application_listener_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: shell/dynamic_application_loader_unittest.cc
diff --git a/shell/dynamic_application_loader_unittest.cc b/shell/dynamic_application_loader_unittest.cc
index ad4726d3eafd6638e3438073a40e5bf1249ade91..2ce00628fa6a77e8d503da2d7481856454245134 100644
--- a/shell/dynamic_application_loader_unittest.cc
+++ b/shell/dynamic_application_loader_unittest.cc
@@ -82,8 +82,9 @@ TEST_F(DynamicApplicationLoaderTest, DoesNotExist) {
ASSERT_TRUE(temp_dir.CreateUniqueTempDir());
base::FilePath nonexistent_file(FILE_PATH_LITERAL("nonexistent.txt"));
GURL url(FilePathToFileURL(temp_dir.path().Append(nonexistent_file)));
- MessagePipe pipe;
- loader_->Load(context_.application_manager(), url, pipe.handle0.Pass(),
+ ShellPtr shell;
+ auto throwaway = GetProxy(&shell);
+ loader_->Load(context_.application_manager(), url, shell.Pass(),
ApplicationLoader::SimpleLoadCallback());
EXPECT_FALSE(state_.runner_was_created);
EXPECT_FALSE(state_.runner_was_started);
« no previous file with comments | « shell/dynamic_application_loader.cc ('k') | shell/external_application_listener_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698