Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Unified Diff: shell/application_manager/shell_impl.h

Issue 873453004: Use ShellPtr type in ApplicationLoader instead of untyped handles (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: fix android Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « shell/application_manager/application_manager_unittest.cc ('k') | shell/application_manager/shell_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: shell/application_manager/shell_impl.h
diff --git a/shell/application_manager/shell_impl.h b/shell/application_manager/shell_impl.h
index ef4de83d628c8f37263bff8012f29da4db428a5b..1226f2a46ebcec4d25b253d76f37ef2078e85380 100644
--- a/shell/application_manager/shell_impl.h
+++ b/shell/application_manager/shell_impl.h
@@ -16,12 +16,7 @@ class ApplicationManager;
class ShellImpl : public Shell, public ErrorHandler {
public:
- ShellImpl(ScopedMessagePipeHandle handle,
- ApplicationManager* manager,
- const GURL& requested_url,
- const GURL& url);
-
- ShellImpl(ShellPtr* ptr,
+ ShellImpl(InterfaceRequest<Shell> shell_request,
ApplicationManager* manager,
const GURL& requested_url,
const GURL& url);
@@ -37,10 +32,6 @@ class ShellImpl : public Shell, public ErrorHandler {
const GURL& requested_url() const { return requested_url_; }
private:
- ShellImpl(ApplicationManager* manager,
- const GURL& requested_url,
- const GURL& url);
-
// Shell implementation:
void ConnectToApplication(const String& app_url,
InterfaceRequest<ServiceProvider> services,
« no previous file with comments | « shell/application_manager/application_manager_unittest.cc ('k') | shell/application_manager/shell_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698