Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Unified Diff: shell/application_manager/application_manager_unittest.cc

Issue 873453004: Use ShellPtr type in ApplicationLoader instead of untyped handles (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: fix android Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « shell/application_manager/application_manager.cc ('k') | shell/application_manager/shell_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: shell/application_manager/application_manager_unittest.cc
diff --git a/shell/application_manager/application_manager_unittest.cc b/shell/application_manager/application_manager_unittest.cc
index a3addb73baf76b8d3d7fd0604d6d1e323e647f57..f3b0503e071e4616cfd07d462f875930d6a6dba8 100644
--- a/shell/application_manager/application_manager_unittest.cc
+++ b/shell/application_manager/application_manager_unittest.cc
@@ -115,10 +115,10 @@ class TestApplicationLoader : public ApplicationLoader,
// ApplicationLoader implementation.
void Load(ApplicationManager* manager,
const GURL& url,
- ScopedMessagePipeHandle shell_handle,
+ ShellPtr shell,
LoadCallback callback) override {
++num_loads_;
- test_app_.reset(new ApplicationImpl(this, shell_handle.Pass()));
+ test_app_.reset(new ApplicationImpl(this, shell.Pass()));
}
void OnApplicationError(ApplicationManager* manager,
@@ -330,9 +330,9 @@ class Tester : public ApplicationDelegate,
private:
void Load(ApplicationManager* manager,
const GURL& url,
- ScopedMessagePipeHandle shell_handle,
+ ShellPtr shell,
LoadCallback callback) override {
- app_.reset(new ApplicationImpl(this, shell_handle.Pass()));
+ app_.reset(new ApplicationImpl(this, shell.Pass()));
}
void OnApplicationError(ApplicationManager* manager,
« no previous file with comments | « shell/application_manager/application_manager.cc ('k') | shell/application_manager/shell_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698