shell/dynamic_application_loader_unittest.cc - Issue 873453004: Use ShellPtr type in ApplicationLoader instead of untyped handles

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: shell/dynamic_application_loader_unittest.cc

Issue 873453004: Use ShellPtr type in ApplicationLoader instead of untyped handles (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: fix android Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « shell/dynamic_application_loader.cc ('k') | shell/external_application_listener_unittest.cc » ('j') | no next file with comments »

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "base/files/scoped_temp_dir.h"	5 #include "base/files/scoped_temp_dir.h"

6 #include "shell/context.h"	6 #include "shell/context.h"

7 #include "shell/dynamic_application_loader.h"	7 #include "shell/dynamic_application_loader.h"

8 #include "shell/dynamic_service_runner.h"	8 #include "shell/dynamic_service_runner.h"

9 #include "shell/filename_util.h"	9 #include "shell/filename_util.h"

10 #include "testing/gtest/include/gtest/gtest.h"	10 #include "testing/gtest/include/gtest/gtest.h"

(...skipping 64 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
75 base::MessageLoop loop_;	75 base::MessageLoop loop_;

76 scoped_ptr<DynamicApplicationLoader> loader_;	76 scoped_ptr<DynamicApplicationLoader> loader_;

77 TestState state_;	77 TestState state_;

78 };	78 };

79	79

80 TEST_F(DynamicApplicationLoaderTest, DoesNotExist) {	80 TEST_F(DynamicApplicationLoaderTest, DoesNotExist) {

81 base::ScopedTempDir temp_dir;	81 base::ScopedTempDir temp_dir;

82 ASSERT_TRUE(temp_dir.CreateUniqueTempDir());	82 ASSERT_TRUE(temp_dir.CreateUniqueTempDir());

83 base::FilePath nonexistent_file(FILE_PATH_LITERAL("nonexistent.txt"));	83 base::FilePath nonexistent_file(FILE_PATH_LITERAL("nonexistent.txt"));

84 GURL url(FilePathToFileURL(temp_dir.path().Append(nonexistent_file)));	84 GURL url(FilePathToFileURL(temp_dir.path().Append(nonexistent_file)));

85 MessagePipe pipe;	85 ShellPtr shell;

86 loader_->Load(context_.application_manager(), url, pipe.handle0.Pass(),	86 auto throwaway = GetProxy(&shell);

	87 loader_->Load(context_.application_manager(), url, shell.Pass(),

87 ApplicationLoader::SimpleLoadCallback());	88 ApplicationLoader::SimpleLoadCallback());

88 EXPECT_FALSE(state_.runner_was_created);	89 EXPECT_FALSE(state_.runner_was_created);

89 EXPECT_FALSE(state_.runner_was_started);	90 EXPECT_FALSE(state_.runner_was_started);

90 EXPECT_FALSE(state_.runner_was_destroyed);	91 EXPECT_FALSE(state_.runner_was_destroyed);

91 }	92 }

92	93

93 } // namespace shell	94 } // namespace shell

94 } // namespace mojo	95 } // namespace mojo

OLD	NEW