Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Side by Side Diff: shell/application_manager/shell_impl.cc

Issue 873453004: Use ShellPtr type in ApplicationLoader instead of untyped handles (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: fix android Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « shell/application_manager/shell_impl.h ('k') | shell/dynamic_application_loader.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "shell/application_manager/shell_impl.h" 5 #include "shell/application_manager/shell_impl.h"
6 6
7 #include "mojo/common/common_type_converters.h" 7 #include "mojo/common/common_type_converters.h"
8 #include "mojo/services/content_handler/public/interfaces/content_handler.mojom. h" 8 #include "mojo/services/content_handler/public/interfaces/content_handler.mojom. h"
9 #include "shell/application_manager/application_manager.h" 9 #include "shell/application_manager/application_manager.h"
10 10
11 namespace mojo { 11 namespace mojo {
12 12
13 ShellImpl::ShellImpl(ScopedMessagePipeHandle handle, 13 ShellImpl::ShellImpl(InterfaceRequest<Shell> shell_request,
14 ApplicationManager* manager, 14 ApplicationManager* manager,
15 const GURL& requested_url, 15 const GURL& requested_url,
16 const GURL& url) 16 const GURL& url)
17 : ShellImpl(manager, requested_url, url) { 17 : manager_(manager),
18 binding_.Bind(handle.Pass()); 18 requested_url_(requested_url),
19 } 19 url_(url),
20 20 binding_(this, shell_request.Pass()) {
21 ShellImpl::ShellImpl(ShellPtr* ptr, 21 binding_.set_error_handler(this);
22 ApplicationManager* manager,
23 const GURL& requested_url,
24 const GURL& url)
25 : ShellImpl(manager, requested_url, url) {
26 binding_.Bind(ptr);
27 } 22 }
28 23
29 ShellImpl::~ShellImpl() { 24 ShellImpl::~ShellImpl() {
30 } 25 }
31 26
32 void ShellImpl::ConnectToClient(const GURL& requestor_url, 27 void ShellImpl::ConnectToClient(const GURL& requestor_url,
33 InterfaceRequest<ServiceProvider> services, 28 InterfaceRequest<ServiceProvider> services,
34 ServiceProviderPtr exposed_services) { 29 ServiceProviderPtr exposed_services) {
35 client()->AcceptConnection(String::From(requestor_url), services.Pass(), 30 client()->AcceptConnection(String::From(requestor_url), services.Pass(),
36 exposed_services.Pass()); 31 exposed_services.Pass());
37 } 32 }
38 33
39 ShellImpl::ShellImpl(ApplicationManager* manager,
40 const GURL& requested_url,
41 const GURL& url)
42 : manager_(manager),
43 requested_url_(requested_url),
44 url_(url),
45 binding_(this) {
46 binding_.set_error_handler(this);
47 }
48
49 // Shell implementation: 34 // Shell implementation:
50 void ShellImpl::ConnectToApplication(const String& app_url, 35 void ShellImpl::ConnectToApplication(const String& app_url,
51 InterfaceRequest<ServiceProvider> services, 36 InterfaceRequest<ServiceProvider> services,
52 ServiceProviderPtr exposed_services) { 37 ServiceProviderPtr exposed_services) {
53 GURL app_gurl(app_url); 38 GURL app_gurl(app_url);
54 if (!app_gurl.is_valid()) { 39 if (!app_gurl.is_valid()) {
55 LOG(ERROR) << "Error: invalid URL: " << app_url; 40 LOG(ERROR) << "Error: invalid URL: " << app_url;
56 return; 41 return;
57 } 42 }
58 manager_->ConnectToApplication(app_gurl, url_, services.Pass(), 43 manager_->ConnectToApplication(app_gurl, url_, services.Pass(),
59 exposed_services.Pass()); 44 exposed_services.Pass());
60 } 45 }
61 46
62 void ShellImpl::OnConnectionError() { 47 void ShellImpl::OnConnectionError() {
63 manager_->OnShellImplError(this); 48 manager_->OnShellImplError(this);
64 } 49 }
65 50
66 } // namespace mojo 51 } // namespace mojo
OLDNEW
« no previous file with comments | « shell/application_manager/shell_impl.h ('k') | shell/dynamic_application_loader.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698