Fix top crasher with ipc fuzzer. Convert hard checks on |is_started| in Gamepad into dchecks and ba…

Fix top crasher with ipc fuzzer. Convert hard checks on |is_started| in Gamepad into dchecks and bailout conditions.

R=bajones, jam
TBR=sadrul@chromium.org
BUG=450268
Committed: https://crrev.com/ea2681e1109946cdcebb326fa85e2aede98e6d05
Cr-Commit-Position: refs/heads/master@{#312987}

[inferno, 2015-01-22 23:42:09]

inferno@chromium.org changed reviewers:
+ b.kelemen@samsung.com
- bajones@adobe.com

[inferno, 2015-01-23 03:11:06]

inferno@chromium.org changed reviewers:
+ sadrul@chromium.org

[inferno, 2015-01-23 03:22:38]

inferno@chromium.org changed reviewers:
+ bajones@chromium.org, jam@chromium.org

[bajones, 2015-01-23 23:03:02]

lgtm

[inferno, 2015-01-23 23:03:38]

The CQ bit was checked by inferno@chromium.org

[commit-bot: I haz the power, 2015-01-23 23:04:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/873453003/20001

[scottmg, 2015-01-23 23:10:31]

scottmg@chromium.org changed reviewers:
+ scottmg@chromium.org

[scottmg, 2015-01-23 23:10:31]

https://codereview.chromium.org/873453003/diff/20001/content/browser/renderer...
File content/browser/renderer_host/gamepad_browser_message_filter.cc (right):

https://codereview.chromium.org/873453003/diff/20001/content/browser/renderer...
content/browser/renderer_host/gamepad_browser_message_filter.cc:51: return;
This should fill out or null *renderer_handle.

[commit-bot: I haz the power, 2015-01-23 23:11:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-23 23:11:59]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[inferno, 2015-01-23 23:13:04]

https://codereview.chromium.org/873453003/diff/20001/content/browser/renderer...
File content/browser/renderer_host/gamepad_browser_message_filter.cc (right):

https://codereview.chromium.org/873453003/diff/20001/content/browser/renderer...
content/browser/renderer_host/gamepad_browser_message_filter.cc:51: return;
On 2015/01/23 23:10:31, scottmg wrote:
> This should fill out or null *renderer_handle.

If is_started is already set, then renderer_handle should already be set (when
is_started was first set). We shouldn't modify that.

[inferno, 2015-01-23 23:13:15]

inferno@chromium.org changed reviewers:
- b.kelemen@samsung.com, sadrul@chromium.org

[jam, 2015-01-23 23:14:53]

lgtm

[inferno, 2015-01-23 23:21:55]

The CQ bit was checked by inferno@chromium.org

[commit-bot: I haz the power, 2015-01-23 23:22:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/873453003/20001

[commit-bot: I haz the power, 2015-01-23 23:23:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-23 23:23:15]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[inferno, 2015-01-23 23:27:01]

The CQ bit was checked by inferno@chromium.org

[commit-bot: I haz the power, 2015-01-23 23:27:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/873453003/20001

[scottmg, 2015-01-23 23:30:20]

https://codereview.chromium.org/873453003/diff/20001/content/browser/renderer...
File content/browser/renderer_host/gamepad_browser_message_filter.cc (right):

https://codereview.chromium.org/873453003/diff/20001/content/browser/renderer...
content/browser/renderer_host/gamepad_browser_message_filter.cc:50: if
(!is_started_)
this condition is wrong; it should be if (is_started)

[inferno, 2015-01-23 23:31:08]

The CQ bit was unchecked by inferno@chromium.org

[inferno, 2015-01-23 23:38:59]

On 2015/01/23 23:30:20, scottmg wrote:
>
https://codereview.chromium.org/873453003/diff/20001/content/browser/renderer...
> File content/browser/renderer_host/gamepad_browser_message_filter.cc (right):
> 
>
https://codereview.chromium.org/873453003/diff/20001/content/browser/renderer...
> content/browser/renderer_host/gamepad_browser_message_filter.cc:50: if
> (!is_started_)
> this condition is wrong; it should be if (is_started)

fixed now. sorry about that. these two functions had opposite calls, so should
have looked closely.

[scottmg, 2015-01-23 23:39:34]

lgtm

[inferno, 2015-01-23 23:39:54]

The CQ bit was checked by inferno@chromium.org

[commit-bot: I haz the power, 2015-01-23 23:41:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/873453003/60001

[commit-bot: I haz the power, 2015-01-24 01:17:29]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-01-24 01:18:38]

Patchset 4 (id:??) landed as
https://crrev.com/ea2681e1109946cdcebb326fa85e2aede98e6d05
Cr-Commit-Position: refs/heads/master@{#312987}

[kbalazs, 2015-01-26 16:03:01]

Can I get access to the bug?

[inferno, 2015-01-26 16:06:30]

On 2015/01/26 16:03:01, kbalazs wrote:
> Can I get access to the bug?

Done, added access for b.kelemen@samsung.com