Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 873453002: Fix ASSERT in ListMarkerPainter::paint (Closed)

Created:
5 years, 11 months ago by rwlbuis
Modified:
5 years, 11 months ago
Reviewers:
chrishtr
CC:
blink-reviews, blink-reviews-paint_chromium.org, slimming-paint-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Fix ASSERT in ListMarkerPainter::paint The original ASSERT checked against capacity but StringBuffer can decide to increase that to 16 when appending characters, which happens in the testcase. Instead test that the reversed length equals the original length. BUG=450603 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188848

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
A LayoutTests/fast/lists/list-marker-text-reverse.html View 1 chunk +7 lines, -0 lines 0 comments Download
A + LayoutTests/fast/lists/list-marker-text-reverse-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/core/paint/ListMarkerPainter.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
rwlbuis
PTAL. I guess removing the ASSERT is also an option.
5 years, 11 months ago (2015-01-22 23:38:05 UTC) #2
chrishtr
lgtm
5 years, 11 months ago (2015-01-22 23:42:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/873453002/1
5 years, 11 months ago (2015-01-22 23:42:46 UTC) #5
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
5 years, 11 months ago (2015-01-23 01:43:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/873453002/1
5 years, 11 months ago (2015-01-23 02:37:57 UTC) #9
commit-bot: I haz the power
5 years, 11 months ago (2015-01-23 02:38:37 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188848

Powered by Google App Engine
This is Rietveld 408576698