Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 873403004: Autofill - show expiration date in CVC prompt when card is expired. (Closed)

Created:
5 years, 11 months ago by Evan Stade
Modified:
5 years, 10 months ago
Reviewers:
brettw
CC:
chromium-reviews, estade+watch_chromium.org, browser-components-watch_chromium.org, rouslan+autofillwatch_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Autofill - show expiration date in CVC prompt when card is expired. (Views) BUG=451654 Committed: https://crrev.com/09bb853459db5a29a64d70f4f15fc57254a47fd9 Cr-Commit-Position: refs/heads/master@{#313186}

Patch Set 1 #

Total comments: 2

Patch Set 2 : inverted check #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -37 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/autofill/CardUnmaskBridge.java View 1 2 4 chunks +11 lines, -7 lines 0 comments Download
M chrome/browser/ui/android/autofill/card_unmask_prompt_view_android.h View 1 2 1 chunk +5 lines, -1 line 0 comments Download
M chrome/browser/ui/android/autofill/card_unmask_prompt_view_android.cc View 1 2 3 chunks +9 lines, -5 lines 0 comments Download
M chrome/browser/ui/autofill/card_unmask_prompt_controller_impl.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M components/autofill/core/browser/webdata/autofill_table.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M ui/android/java/res/layout/autofill_card_unmask_prompt.xml View 1 2 2 chunks +20 lines, -5 lines 0 comments Download
M ui/android/java/src/org/chromium/ui/autofill/CardUnmaskPrompt.java View 1 2 9 chunks +78 lines, -15 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Evan Stade
5 years, 11 months ago (2015-01-26 23:52:23 UTC) #2
brettw
lgtm https://codereview.chromium.org/873403004/diff/1/chrome/browser/ui/views/autofill/card_unmask_prompt_views.cc File chrome/browser/ui/views/autofill/card_unmask_prompt_views.cc (right): https://codereview.chromium.org/873403004/diff/1/chrome/browser/ui/views/autofill/card_unmask_prompt_views.cc#newcode138 chrome/browser/ui/views/autofill/card_unmask_prompt_views.cc:138: (year_input_ || Did you mean !year_input_ here?
5 years, 11 months ago (2015-01-27 00:12:37 UTC) #3
Evan Stade
https://codereview.chromium.org/873403004/diff/1/chrome/browser/ui/views/autofill/card_unmask_prompt_views.cc File chrome/browser/ui/views/autofill/card_unmask_prompt_views.cc (right): https://codereview.chromium.org/873403004/diff/1/chrome/browser/ui/views/autofill/card_unmask_prompt_views.cc#newcode138 chrome/browser/ui/views/autofill/card_unmask_prompt_views.cc:138: (year_input_ || On 2015/01/27 00:12:37, brettw wrote: > Did ...
5 years, 11 months ago (2015-01-27 00:14:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/873403004/20001
5 years, 11 months ago (2015-01-27 00:15:41 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-27 01:16:05 UTC) #7
commit-bot: I haz the power
5 years, 11 months ago (2015-01-27 01:17:34 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/09bb853459db5a29a64d70f4f15fc57254a47fd9
Cr-Commit-Position: refs/heads/master@{#313186}

Powered by Google App Engine
This is Rietveld 408576698