Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Side by Side Diff: content/renderer/render_view_impl.cc

Issue 8734007: Merge 110556 - Fix next_page_id_ in a NTP forced to share an existing WebUI process. (Closed) Base URL: svn://svn.chromium.org/chrome/branches/912/src/
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « content/renderer/render_thread_impl.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/renderer/render_view_impl.h" 5 #include "content/renderer/render_view_impl.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <cmath> 8 #include <cmath>
9 #include <string> 9 #include <string>
10 #include <vector> 10 #include <vector>
(...skipping 472 matching lines...) Expand 10 before | Expand all | Expand 10 after
483 renderer_prefs, 483 renderer_prefs,
484 webkit_prefs, 484 webkit_prefs,
485 counter, 485 counter,
486 routing_id, 486 routing_id,
487 session_storage_namespace_id, 487 session_storage_namespace_id,
488 frame_name); // adds reference 488 frame_name); // adds reference
489 } 489 }
490 490
491 // static 491 // static
492 void RenderViewImpl::SetNextPageID(int32 next_page_id) { 492 void RenderViewImpl::SetNextPageID(int32 next_page_id) {
493 // This method should only be called during process startup, and the given 493 // This method is called on startup or when the browser knows it needs to
494 // page id had better not exceed our current next page id! 494 // inflate the page_id when re-using the process. The renderer may have
495 DCHECK_EQ(next_page_id_, 1); 495 // incremented this just as the browser was sending the message, but we
496 DCHECK(next_page_id >= next_page_id_); 496 // only care that next_page_id_ is at least as large as next_page_id.
497 next_page_id_ = next_page_id; 497 if (next_page_id > next_page_id_)
498 next_page_id_ = next_page_id;
498 } 499 }
499 500
500 void RenderViewImpl::AddObserver(RenderViewObserver* observer) { 501 void RenderViewImpl::AddObserver(RenderViewObserver* observer) {
501 observers_.AddObserver(observer); 502 observers_.AddObserver(observer);
502 } 503 }
503 504
504 void RenderViewImpl::RemoveObserver(RenderViewObserver* observer) { 505 void RenderViewImpl::RemoveObserver(RenderViewObserver* observer) {
505 observer->RenderViewGone(); 506 observer->RenderViewGone();
506 observers_.RemoveObserver(observer); 507 observers_.RemoveObserver(observer);
507 } 508 }
(...skipping 4125 matching lines...) Expand 10 before | Expand all | Expand 10 after
4633 pepper_delegate_.OnLockMouseACK(succeeded); 4634 pepper_delegate_.OnLockMouseACK(succeeded);
4634 } 4635 }
4635 4636
4636 void RenderViewImpl::OnMouseLockLost() { 4637 void RenderViewImpl::OnMouseLockLost() {
4637 pepper_delegate_.OnMouseLockLost(); 4638 pepper_delegate_.OnMouseLockLost();
4638 } 4639 }
4639 4640
4640 bool RenderViewImpl::WebWidgetHandlesCompositorScheduling() const { 4641 bool RenderViewImpl::WebWidgetHandlesCompositorScheduling() const {
4641 return webview()->settings()->useThreadedCompositor(); 4642 return webview()->settings()->useThreadedCompositor();
4642 } 4643 }
OLDNEW
« no previous file with comments | « content/renderer/render_thread_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698