Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 873393002: speedup mipmap building (Closed)

Created:
5 years, 11 months ago by reed1
Modified:
5 years, 11 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

speedup mipmap building mipmap_build benchmark: before: 3.36ms after: 2.20ms BUG=skia: Committed: https://skia.googlesource.com/skia/+/dc14fa4ec7739465d9bb9dbf1f0e537c80ad867f

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -36 lines) Patch
M src/core/SkMipMap.cpp View 1 5 chunks +93 lines, -36 lines 0 comments Download

Messages

Total messages: 18 (6 generated)
reed1
ptal
5 years, 11 months ago (2015-01-26 19:21:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/873393002/1
5 years, 11 months ago (2015-01-26 19:36:31 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 11 months ago (2015-01-26 19:36:32 UTC) #5
reed1
want to add a bench before landing
5 years, 11 months ago (2015-01-26 19:39:44 UTC) #7
robertphillips
This l g t m but I am curious about the perf
5 years, 11 months ago (2015-01-26 19:47:44 UTC) #8
reed1
now with bench results (and bug fix)
5 years, 11 months ago (2015-01-26 21:10:51 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/873393002/20001
5 years, 11 months ago (2015-01-26 21:11:11 UTC) #11
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 11 months ago (2015-01-26 21:11:12 UTC) #12
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Please ask for an LGTM from a full ...
5 years, 11 months ago (2015-01-27 03:11:13 UTC) #14
robertphillips
lgtm
5 years, 11 months ago (2015-01-27 13:00:50 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/873393002/20001
5 years, 11 months ago (2015-01-27 13:01:43 UTC) #17
commit-bot: I haz the power
5 years, 11 months ago (2015-01-27 13:01:54 UTC) #18
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/dc14fa4ec7739465d9bb9dbf1f0e537c80ad867f

Powered by Google App Engine
This is Rietveld 408576698