Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 873333004: s/sk_tools::DrawCheckerboard/sk_tool_utils::draw_checkerboard/ (Closed)

Created:
5 years, 11 months ago by hal.canary
Modified:
5 years, 11 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

s/sk_tools::DrawCheckerboard/sk_tool_utils::draw_checkerboard/ BUG=skia: Committed: https://skia.googlesource.com/skia/+/b0cce2c1d37d4bf5b89da6c70062209ac4e0e643

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -93 lines) Patch
M gm/colorwheel.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M gm/displacement.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M gm/imagefiltersclipped.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M gm/imagefiltersscaled.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M gm/offsetimagefilter.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M gm/tileimagefilter.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M gm/xfermodeimagefilter.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M gyp/SampleApp.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M gyp/gmslides.gypi View 1 chunk +0 lines, -3 lines 0 comments Download
M gyp/tools.gyp View 1 chunk +0 lines, -7 lines 0 comments Download
M samplecode/SampleColorFilter.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M samplecode/SampleFatBits.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M samplecode/SampleUnpremul.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
D tools/Checkerboard.h View 1 chunk +0 lines, -34 lines 0 comments Download
D tools/Checkerboard.cpp View 1 chunk +0 lines, -28 lines 0 comments Download
M tools/sk_tool_utils.h View 2 chunks +17 lines, -0 lines 0 comments Download
M tools/sk_tool_utils.cpp View 2 chunks +17 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/873333004/1
5 years, 11 months ago (2015-01-26 20:40:01 UTC) #2
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 11 months ago (2015-01-26 20:40:02 UTC) #3
hal.canary
5 years, 11 months ago (2015-01-26 20:40:37 UTC) #6
reed1
lgtm
5 years, 11 months ago (2015-01-26 20:42:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/873333004/1
5 years, 11 months ago (2015-01-26 20:43:01 UTC) #9
commit-bot: I haz the power
5 years, 11 months ago (2015-01-26 20:49:04 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/b0cce2c1d37d4bf5b89da6c70062209ac4e0e643

Powered by Google App Engine
This is Rietveld 408576698