[Password manager tests] Write to spreadsheets.

[Password manager tests] Write to spreadsheets.

Writes results of running tests to trix instead of local file.

R=vabr@chromium.org
BUG=435249
Committed: https://crrev.com/c503f65196a1a19fa5dd384d642d018bbc3d857e
Cr-Commit-Position: refs/heads/master@{#313508}

[melandory, 2015-01-26 17:47:52]

Hi Vaclav,

here is CL with rudimentary logging to spread sheets. It's very very far from
perfect. It's up to you to decide should we commit it or leave for better time.

Thanks!

P.S. Ini file has follwing format:
[credentials]
pkey=full_path
client_email=email_assigned_by_google_dev_console
[drive]
key=sheet_key_from_sheet_url
[data_files]
passwords_path=full_path_to_the_file_with_passwords

[vabr (Chromium), 2015-01-27 13:09:15]

Thanks, Tanja!

I believe there is value in landing this, because it is better than the current
state.

If you have time to incorporate the 3 straightforward comments below, then
please do so and land this, that will LGTM.

Otherwise I can pick up this CL from you. Just let me know.

Thanks,
Vaclav

https://codereview.chromium.org/873333002/diff/1/components/test/data/passwor...
File components/test/data/password_manager/automated_tests/run_tests.py (right):

https://codereview.chromium.org/873333002/diff/1/components/test/data/passwor...
components/test/data/password_manager/automated_tests/run_tests.py:6: """This
file allows the bots to be easily configure and run the tests."""
Could you please add a comment like below?
Running this script requires passing --config-path with a path to a config file
of the following structure:
[credentials]
pkey=full_path
client_email=email_assigned_by_google_dev_console
[drive]
key=sheet_key_from_sheet_url
[data_files]
passwords_path=full_path_to_the_file_with_passwords

https://codereview.chromium.org/873333002/diff/1/components/test/data/passwor...
components/test/data/password_manager/automated_tests/run_tests.py:40: # to
websitetests, because this was we do not need to write results of run
typo: was -> way

https://codereview.chromium.org/873333002/diff/1/components/test/data/passwor...
components/test/data/password_manager/automated_tests/run_tests.py:73:
os.system("timeout 600 %s" % test_cmd)
Please add:
# TODO(vabr): Use subprocess.call.

[melandory, 2015-01-27 13:11:20]

On 2015/01/27 13:09:15, vabr (Chromium) wrote:
> Thanks, Tanja!
> 
> I believe there is value in landing this, because it is better than the
current
> state.
> 
> If you have time to incorporate the 3 straightforward comments below, then
> please do so and land this, that will LGTM.
> 
> Otherwise I can pick up this CL from you. Just let me know.
I will do it.

[melandory, 2015-01-27 13:24:56]

Patchset #2 (id:20001) has been deleted

[melandory, 2015-01-27 13:25:22]

https://codereview.chromium.org/873333002/diff/1/components/test/data/passwor...
File components/test/data/password_manager/automated_tests/run_tests.py (right):

https://codereview.chromium.org/873333002/diff/1/components/test/data/passwor...
components/test/data/password_manager/automated_tests/run_tests.py:6: """This
file allows the bots to be easily configure and run the tests."""
On 2015/01/27 13:09:15, vabr (Chromium) wrote:
> Could you please add a comment like below?
> Running this script requires passing --config-path with a path to a config
file
> of the following structure:
> [credentials]
> pkey=full_path
> client_email=email_assigned_by_google_dev_console
> [drive]
> key=sheet_key_from_sheet_url
> [data_files]
> passwords_path=full_path_to_the_file_with_passwords

Done.

https://codereview.chromium.org/873333002/diff/1/components/test/data/passwor...
components/test/data/password_manager/automated_tests/run_tests.py:40: # to
websitetests, because this was we do not need to write results of run
On 2015/01/27 13:09:15, vabr (Chromium) wrote:
> typo: was -> way

Done.

https://codereview.chromium.org/873333002/diff/1/components/test/data/passwor...
components/test/data/password_manager/automated_tests/run_tests.py:73:
os.system("timeout 600 %s" % test_cmd)
On 2015/01/27 13:09:15, vabr (Chromium) wrote:
> Please add:
> # TODO(vabr): Use subprocess.call.

Done.

[vabr (Chromium), 2015-01-27 13:32:45]

Thanks a lot for the changes, LGTM!

Vaclav

[melandory, 2015-01-28 12:51:04]

The CQ bit was checked by melandory@chromium.org

[commit-bot: I haz the power, 2015-01-28 12:51:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/873333002/40001

[commit-bot: I haz the power, 2015-01-28 14:44:34]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2015-01-28 14:45:46]

Patchset 2 (id:??) landed as
https://crrev.com/c503f65196a1a19fa5dd384d642d018bbc3d857e
Cr-Commit-Position: refs/heads/master@{#313508}