Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 <?xml version="1.0" encoding="utf-8"?> | 1 <?xml version="1.0" encoding="utf-8"?> |
| 2 <!-- Copyright 2014 The Chromium Authors. All rights reserved. | 2 <!-- Copyright 2014 The Chromium Authors. All rights reserved. |
| 3 | 3 |
| 4 Use of this source code is governed by a BSD-style license that can be | 4 Use of this source code is governed by a BSD-style license that can be |
| 5 found in the LICENSE file. | 5 found in the LICENSE file. |
| 6 --> | 6 --> |
| 7 | 7 |
| 8 <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android" | 8 <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android" |
| 9 android:layout_width="wrap_content" | 9 android:layout_width="wrap_content" |
| 10 android:layout_height="wrap_content" | 10 android:layout_height="wrap_content" |
| 11 android:orientation="vertical"> | 11 android:orientation="vertical"> |
| 12 | 12 |
| 13 <TextView | 13 <TextView |
| 14 android:id="@+id/instructions" | 14 android:id="@+id/instructions" |
| 15 android:layout_width="match_parent" | 15 android:layout_width="match_parent" |
| 16 android:layout_height="wrap_content" | 16 android:layout_height="wrap_content" |
| 17 android:textSize="20sp" | 17 android:textSize="16sp" |
| 18 android:paddingStart="5dp" | 18 android:layout_marginStart="24dp" |
| 19 android:paddingEnd="5dp" | 19 android:layout_marginEnd="10dp" |
| 20 android:paddingBottom="5dp" | 20 android:layout_marginBottom="8dp" |
| 21 android:paddingTop="5dp" | 21 android:layout_marginTop="10dp" |
| 22 android:gravity="start" /> | 22 android:gravity="start" /> |
| 23 | 23 |
| 24 <LinearLayout | 24 <LinearLayout |
| 25 android:layout_width="match_parent" | 25 android:layout_width="match_parent" |
| 26 android:layout_height="wrap_content" | 26 android:layout_height="wrap_content" |
| 27 android:orientation="horizontal"> | 27 android:orientation="horizontal"> |
| 28 | 28 |
| 29 <!-- TODO(estade): add accessibility content descriptions. --> | |
| 30 <Spinner | |
| 31 android:id="@+id/expiration_month" | |
| 32 android:layout_width="wrap_content" | |
| 33 android:layout_height="match_parent" | |
|
newt (away)
2015/01/29 04:42:27
Height should be wrap_content. Same below.
Evan Stade
2015/01/30 02:13:23
Done.
| |
| 34 android:layout_marginStart="16dp" | |
| 35 android:visibility="gone" /> | |
| 36 | |
| 37 <Spinner | |
| 38 android:id="@+id/expiration_year" | |
| 39 android:layout_width="wrap_content" | |
| 40 android:layout_height="match_parent" | |
| 41 android:layout_marginStart="16dp" | |
| 42 android:visibility="gone" /> | |
| 43 | |
| 29 <EditText | 44 <EditText |
| 30 android:id="@+id/card_unmask_input" | 45 android:id="@+id/card_unmask_input" |
| 31 android:inputType="number" | 46 android:inputType="number" |
| 32 android:layout_height="wrap_content" | 47 android:layout_height="wrap_content" |
| 33 android:layout_width="wrap_content" | 48 android:layout_width="wrap_content" |
| 34 android:layout_marginStart="16dp" | 49 android:layout_marginStart="16dp" |
| 35 android:layout_marginEnd="16dp" | 50 android:layout_marginEnd="16dp" |
| 36 android:ems="4" | 51 android:ems="4" |
| 37 android:hint="@string/card_unmask_input_hint" /> | 52 android:hint="@string/card_unmask_input_hint" /> |
| 38 | 53 |
| (...skipping 16 matching lines...) Expand all Loading... | |
| 55 <TextView | 70 <TextView |
| 56 android:id="@+id/verification_message" | 71 android:id="@+id/verification_message" |
| 57 android:layout_width="wrap_content" | 72 android:layout_width="wrap_content" |
| 58 android:layout_height="wrap_content" | 73 android:layout_height="wrap_content" |
| 59 android:layout_gravity="center_vertical" | 74 android:layout_gravity="center_vertical" |
| 60 android:gravity="start" | 75 android:gravity="start" |
| 61 android:visibility="gone" /> | 76 android:visibility="gone" /> |
| 62 </LinearLayout> | 77 </LinearLayout> |
| 63 | 78 |
| 64 </LinearLayout> | 79 </LinearLayout> |
| OLD | NEW |