Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issue 873313009: Add logging to debug DumpAccessibilityEvent* tests WinClang* (Closed)

Created:
5 years, 10 months ago by dmazzoni
Modified:
5 years, 10 months ago
Reviewers:
Nico, Paweł Hajdan Jr.
CC:
chromium-reviews, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, jam, yuzo+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add logging to debug DumpAccessibilityEvent* tests WinClang* Note that accessibility_event_recorder_win a test helper, this doesn't add logging to Chrome. BUG=440579 NOPRESUBMIT=true Committed: https://crrev.com/057083929d5871f570909340dfe36564880380f6 Cr-Commit-Position: refs/heads/master@{#313677}

Patch Set 1 #

Patch Set 2 : Add bug link and temporarily disable swarming on CrWinClang #

Total comments: 1

Patch Set 3 : Just logging change for now #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -5 lines) Patch
M content/browser/accessibility/accessibility_event_recorder_win.cc View 1 5 chunks +19 lines, -5 lines 0 comments Download

Messages

Total messages: 17 (5 generated)
dmazzoni
5 years, 10 months ago (2015-01-28 21:31:26 UTC) #2
Nico
lgtm, thanks (maybe include a bug link and a TODO to remove all the logging; ...
5 years, 10 months ago (2015-01-28 22:31:52 UTC) #3
Nico
and if you want, you can unswarm this test on CrWinClang tester, then a test ...
5 years, 10 months ago (2015-01-28 22:32:15 UTC) #4
dmazzoni
+phajdan.jr for testing/buildbot Nico, I'm assuming that's what you had in mind?
5 years, 10 months ago (2015-01-28 22:39:25 UTC) #6
dmazzoni
On 2015/01/28 22:31:52, Nico wrote: > (maybe include a bug link and a TODO to ...
5 years, 10 months ago (2015-01-28 22:39:47 UTC) #7
Nico
https://codereview.chromium.org/873313009/diff/20001/testing/buildbot/chromium.fyi.json File testing/buildbot/chromium.fyi.json (right): https://codereview.chromium.org/873313009/diff/20001/testing/buildbot/chromium.fyi.json#newcode406 testing/buildbot/chromium.fyi.json:406: }, I would've replaced this whole block with just ...
5 years, 10 months ago (2015-01-29 02:16:54 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/873313009/40001
5 years, 10 months ago (2015-01-29 07:29:17 UTC) #10
dmazzoni
These tests just flaked on the main waterfall. I'm going to land the change without ...
5 years, 10 months ago (2015-01-29 07:29:24 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/39114)
5 years, 10 months ago (2015-01-29 07:34:57 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/873313009/40001
5 years, 10 months ago (2015-01-29 08:03:48 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-01-29 08:04:41 UTC) #16
commit-bot: I haz the power
5 years, 10 months ago (2015-01-29 08:07:23 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/057083929d5871f570909340dfe36564880380f6
Cr-Commit-Position: refs/heads/master@{#313677}

Powered by Google App Engine
This is Rietveld 408576698