Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 873293006: Revert of Remove Client= from device/serial/data_stream.mojom. (Closed)

Created:
5 years, 10 months ago by Sam McNally
Modified:
5 years, 10 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, chromium-apps-reviews_chromium.org, darin (slow to review), ben+mojo_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove Client= from device/serial/data_stream.mojom. (patchset #1 id:20001 of https://codereview.chromium.org/889283002/) Reason for revert: Switching to two pipes broke FIFO assumption, causing DataSinkTest.CancelDuringError and SerialConnectionTest.Cancel to become flaky Original issue's description: > Remove Client= from device/serial/data_stream.mojom. > > BUG=451321 > > Committed: https://crrev.com/bc78a2320b50eba4fe397f1f838a82ad30b16cd6 > Cr-Commit-Position: refs/heads/master@{#314231} TBR=rockot@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=451321 Committed: https://crrev.com/4b7484b40acaec1d7904c5f38bd4be116468013a Cr-Commit-Position: refs/heads/master@{#314524}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+156 lines, -352 lines) Patch
M device/serial/data_receiver.h View 2 chunks +0 lines, -2 lines 0 comments Download
M device/serial/data_receiver.cc View 1 chunk +4 lines, -7 lines 0 comments Download
M device/serial/data_sender.h View 2 chunks +0 lines, -2 lines 0 comments Download
M device/serial/data_sender.cc View 1 chunk +1 line, -3 lines 0 comments Download
M device/serial/data_sink_receiver.h View 3 chunks +2 lines, -8 lines 0 comments Download
M device/serial/data_sink_receiver.cc View 4 chunks +8 lines, -14 lines 0 comments Download
M device/serial/data_sink_unittest.cc View 1 chunk +7 lines, -10 lines 0 comments Download
M device/serial/data_source_sender.h View 3 chunks +2 lines, -8 lines 0 comments Download
M device/serial/data_source_sender.cc View 3 chunks +5 lines, -12 lines 0 comments Download
M device/serial/data_source_unittest.cc View 1 chunk +6 lines, -12 lines 0 comments Download
M device/serial/data_stream.mojom View 2 chunks +2 lines, -0 lines 0 comments Download
M device/serial/data_stream_serialization.mojom View 2 chunks +0 lines, -4 lines 0 comments Download
M device/serial/serial.mojom View 1 chunk +1 line, -3 lines 0 comments Download
M device/serial/serial_connection.h View 1 chunk +1 line, -3 lines 0 comments Download
M device/serial/serial_connection.cc View 1 chunk +13 lines, -12 lines 0 comments Download
M device/serial/serial_connection_factory.h View 1 chunk +1 line, -3 lines 0 comments Download
M device/serial/serial_connection_factory.cc View 5 chunks +11 lines, -19 lines 0 comments Download
M device/serial/serial_connection_unittest.cc View 1 chunk +11 lines, -17 lines 0 comments Download
M device/serial/serial_service_impl.h View 1 chunk +5 lines, -8 lines 0 comments Download
M device/serial/serial_service_impl.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M device/serial/serial_service_unittest.cc View 1 chunk +5 lines, -8 lines 0 comments Download
M extensions/renderer/api/serial/data_receiver_unittest.cc View 3 chunks +8 lines, -59 lines 0 comments Download
M extensions/renderer/api/serial/data_sender_unittest.cc View 3 chunks +9 lines, -58 lines 0 comments Download
M extensions/renderer/resources/data_receiver.js View 8 chunks +17 lines, -24 lines 0 comments Download
M extensions/renderer/resources/data_sender.js View 6 chunks +8 lines, -22 lines 0 comments Download
M extensions/renderer/resources/serial_service.js View 4 chunks +5 lines, -16 lines 0 comments Download
M extensions/test/data/data_receiver_unittest.js View 1 chunk +9 lines, -6 lines 0 comments Download
M extensions/test/data/data_sender_unittest.js View 1 chunk +9 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Sam McNally
Created Revert of Remove Client= from device/serial/data_stream.mojom.
5 years, 10 months ago (2015-02-04 08:52:24 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/873293006/1
5 years, 10 months ago (2015-02-04 08:53:20 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-04 08:54:24 UTC) #3
commit-bot: I haz the power
5 years, 10 months ago (2015-02-04 08:55:05 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4b7484b40acaec1d7904c5f38bd4be116468013a
Cr-Commit-Position: refs/heads/master@{#314524}

Powered by Google App Engine
This is Rietveld 408576698