Invalid press events don't create multiple pointers with the same id.

Invalid press events don't create multiple pointers with the same id.

Previously if we got an invalid event stream such as

Press id 0
Press id 0

MotionEventAura would happily add the second pointer. Now we replace
the first pointer with the second pointer.

This work around is required due to crbug.com/373125.

BUG=450880
Committed: https://crrev.com/b88d572b627a99714051bf057afdb2ead4f58489
Cr-Commit-Position: refs/heads/master@{#313116}

[tdresser, 2015-01-26 17:02:13]

tdresser@chromium.org changed reviewers:
+ jdduke@chromium.org

[tdresser, 2015-01-26 17:02:14]

PTAL.

This will need to be merged into 41.

[jdduke (slow), 2015-01-26 17:16:19]

lgtm with one thought.

https://codereview.chromium.org/873283003/diff/20001/ui/events/gestures/motio...
File ui/events/gestures/motion_event_aura.cc (right):

https://codereview.chromium.org/873283003/diff/20001/ui/events/gestures/motio...
ui/events/gestures/motion_event_aura.cc:92: UpdateTouch(touch);
I guess the alternative is cancelling the previously pressed touch and using the
usual update flow, e.g.

if (touch.type() == ET_TOUCH_PRESSED && pointer_id_is_active) {
  // ...
  OnTouch(TouchEvent(ET_TOUCH_CANCELLED, touch.location(), touch.touch_id(),
touch.time-stamp());
  DCHECK_EQ(-1, FindPointerIndexOfId(touch.touch_id());
} else ...

Not sure if that's any cleaner?

[tdresser, 2015-01-26 17:48:03]

Yeah, that's a bit cleaner.

Are you happy with this?

https://codereview.chromium.org/873283003/diff/20001/ui/events/gestures/motio...
File ui/events/gestures/motion_event_aura.cc (right):

https://codereview.chromium.org/873283003/diff/20001/ui/events/gestures/motio...
ui/events/gestures/motion_event_aura.cc:92: UpdateTouch(touch);
On 2015/01/26 17:16:19, jdduke wrote:
> I guess the alternative is cancelling the previously pressed touch and using
the
> usual update flow, e.g.
> 
> if (touch.type() == ET_TOUCH_PRESSED && pointer_id_is_active) {
>   // ...
>   OnTouch(TouchEvent(ET_TOUCH_CANCELLED, touch.location(), touch.touch_id(),
> touch.time-stamp());
>   DCHECK_EQ(-1, FindPointerIndexOfId(touch.touch_id());
> } else ...
> 
> Not sure if that's any cleaner?

Done.

[jdduke (slow), 2015-01-26 17:51:12]

Yeah, maybe not all that much cleaner =/, but I guess it follows the expected
sequence pattern. still lgtm.

https://codereview.chromium.org/873283003/diff/40001/ui/events/gestures/motio...
File ui/events/gestures/motion_event_aura.cc (right):

https://codereview.chromium.org/873283003/diff/40001/ui/events/gestures/motio...
ui/events/gestures/motion_event_aura.cc:93: OnTouch(cancel);
Oh, I forgot about this cleanup dependency =/.

[tdresser, 2015-01-26 17:53:06]

The CQ bit was checked by tdresser@chromium.org

[commit-bot: I haz the power, 2015-01-26 17:54:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/873283003/40001

[commit-bot: I haz the power, 2015-01-26 19:00:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-26 19:00:23]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  win_chromium_x64_rel_ng on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[tdresser, 2015-01-26 19:08:38]

The CQ bit was checked by tdresser@chromium.org

[commit-bot: I haz the power, 2015-01-26 19:09:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/873283003/60001

[commit-bot: I haz the power, 2015-01-26 20:25:30]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-01-26 20:26:16]

Patchset 4 (id:??) landed as
https://crrev.com/b88d572b627a99714051bf057afdb2ead4f58489
Cr-Commit-Position: refs/heads/master@{#313116}