Add IPC fuzzer GenerateTraits for some cc types.

Add IPC fuzzer GenerateTraits for some cc types.

BUG=450268
R=inferno@chromium.org,tsepez@chromium.org

Committed: https://crrev.com/1ff18517c604201208b753c10bcebdcc986f7a17
Cr-Commit-Position: refs/heads/master@{#313632}

[inferno, 2015-01-28 22:44:36]

lgtm with nits/

https://codereview.chromium.org/873253004/diff/60001/tools/ipc_fuzzer/mutate/...
File tools/ipc_fuzzer/mutate/generate.cc (right):

https://codereview.chromium.org/873253004/diff/60001/tools/ipc_fuzzer/mutate/...
tools/ipc_fuzzer/mutate/generate.cc:715: p->delegated_frame_data.reset(new
cc::DelegatedFrameData);
Should we be generating all of these three at once or just one out of three -
https://code.google.com/p/chromium/codesearch#chromium/src/content/common/cc_...

https://codereview.chromium.org/873253004/diff/60001/tools/ipc_fuzzer/mutate/...
tools/ipc_fuzzer/mutate/generate.cc:715: p->delegated_frame_data.reset(new
cc::DelegatedFrameData);
empty constructor for clarity everywhere
s/p->delegated_frame_data.reset(new
cc::DelegatedFrameData)/p->delegated_frame_data.reset(new
cc::DelegatedFrameData())

https://codereview.chromium.org/873253004/diff/60001/tools/ipc_fuzzer/mutate/...
tools/ipc_fuzzer/mutate/generate.cc:784: if (!GenerateParam(&p->quad_list,
generator))
please add fixme for
https://code.google.com/p/chromium/codesearch#chromium/src/cc/quads/render_pa...
 ScopedPtrVector<CopyOutputRequest> copy_requests;

https://codereview.chromium.org/873253004/diff/60001/tools/ipc_fuzzer/mutate/...
tools/ipc_fuzzer/mutate/generate.cc:795: size_t count = RandInRange(5);
Why just 5 ? lets probably put that 10 we use other places in a global and use
it everywhere.

[Tom Sepez, 2015-01-28 22:58:09]

lgtm

https://codereview.chromium.org/873253004/diff/60001/tools/ipc_fuzzer/mutate/...
File tools/ipc_fuzzer/mutate/generate.cc (right):

https://codereview.chromium.org/873253004/diff/60001/tools/ipc_fuzzer/mutate/...
tools/ipc_fuzzer/mutate/generate.cc:758: // FIXME(mbarbella): This should
actually generate something.
nit: style guide says TODO(mbarbella): ..

[Martin Barbella, 2015-01-28 23:03:59]

https://codereview.chromium.org/873253004/diff/60001/tools/ipc_fuzzer/mutate/...
File tools/ipc_fuzzer/mutate/generate.cc (right):

https://codereview.chromium.org/873253004/diff/60001/tools/ipc_fuzzer/mutate/...
tools/ipc_fuzzer/mutate/generate.cc:715: p->delegated_frame_data.reset(new
cc::DelegatedFrameData);
On 2015/01/28 22:44:36, inferno wrote:
> Should we be generating all of these three at once or just one out of three -
>
https://code.google.com/p/chromium/codesearch#chromium/src/content/common/cc_...

Yeah, it looks like we should only be generating one here.

https://codereview.chromium.org/873253004/diff/60001/tools/ipc_fuzzer/mutate/...
tools/ipc_fuzzer/mutate/generate.cc:784: if (!GenerateParam(&p->quad_list,
generator))
On 2015/01/28 22:44:36, inferno wrote:
> please add fixme for
>
https://code.google.com/p/chromium/codesearch#chromium/src/cc/quads/render_pa...
>  ScopedPtrVector<CopyOutputRequest> copy_requests;

I didn't add it because it doesn't seem to be getting written. Should I just add
a comment here to mention it?

https://code.google.com/p/chromium/codesearch#chromium/src/content/common/cc_...

[Martin Barbella, 2015-01-28 23:32:59]

https://codereview.chromium.org/873253004/diff/60001/tools/ipc_fuzzer/mutate/...
File tools/ipc_fuzzer/mutate/generate.cc (right):

https://codereview.chromium.org/873253004/diff/60001/tools/ipc_fuzzer/mutate/...
tools/ipc_fuzzer/mutate/generate.cc:715: p->delegated_frame_data.reset(new
cc::DelegatedFrameData);
On 2015/01/28 23:03:59, mbarbella wrote:
> On 2015/01/28 22:44:36, inferno wrote:
> > Should we be generating all of these three at once or just one out of three
-
> >
>
https://code.google.com/p/chromium/codesearch#chromium/src/content/common/cc_...
> 
> Yeah, it looks like we should only be generating one here.

Both comments addressed.

https://codereview.chromium.org/873253004/diff/60001/tools/ipc_fuzzer/mutate/...
tools/ipc_fuzzer/mutate/generate.cc:758: // FIXME(mbarbella): This should
actually generate something.
On 2015/01/28 22:58:09, Tom Sepez wrote:
> nit: style guide says TODO(mbarbella): ..

Done.

https://codereview.chromium.org/873253004/diff/60001/tools/ipc_fuzzer/mutate/...
tools/ipc_fuzzer/mutate/generate.cc:784: if (!GenerateParam(&p->quad_list,
generator))
On 2015/01/28 23:03:59, mbarbella wrote:
> On 2015/01/28 22:44:36, inferno wrote:
> > please add fixme for
> >
>
https://code.google.com/p/chromium/codesearch#chromium/src/cc/quads/render_pa...
> >  ScopedPtrVector<CopyOutputRequest> copy_requests;
> 
> I didn't add it because it doesn't seem to be getting written. Should I just
add
> a comment here to mention it?
> 
>
https://code.google.com/p/chromium/codesearch#chromium/src/content/common/cc_...

Left a comment here. Could you take a look to make sure I'm not missing
something here, though?

https://codereview.chromium.org/873253004/diff/60001/tools/ipc_fuzzer/mutate/...
tools/ipc_fuzzer/mutate/generate.cc:795: size_t count = RandInRange(5);
On 2015/01/28 22:44:36, inferno wrote:
> Why just 5 ? lets probably put that 10 we use other places in a global and use
> it everywhere.

Done.

[inferno, 2015-01-28 23:38:59]

lgtm

[Martin Barbella, 2015-01-28 23:39:35]

The CQ bit was checked by mbarbella@chromium.org

[commit-bot: I haz the power, 2015-01-28 23:41:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/873253004/80001

[commit-bot: I haz the power, 2015-01-29 00:15:42]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-01-29 00:16:44]

Patchset 5 (id:??) landed as
https://crrev.com/1ff18517c604201208b753c10bcebdcc986f7a17
Cr-Commit-Position: refs/heads/master@{#313632}