Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 873253003: Resolve URLs passed on the command line relative to the CWD. (Closed)

Created:
5 years, 11 months ago by Nick Bray (chromium)
Modified:
5 years, 10 months ago
Reviewers:
qsr, abarth-chromium
CC:
mojo-reviews_chromium.org, yzshen+watch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Resolve URLs passed on the command line relative to the CWD. This will make it easier to pass arbitrary files to mojo_shell for testing. BUG=401761 R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/863634382256c5ed9046a688aa675287d01ab898

Patch Set 1 #

Patch Set 2 : Comments #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -7 lines) Patch
M shell/command_line_util.h View 1 chunk +2 lines, -1 line 0 comments Download
M shell/command_line_util.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M shell/command_line_util_unittest.cc View 2 chunks +7 lines, -2 lines 0 comments Download
M shell/context.h View 1 2 chunks +9 lines, -0 lines 0 comments Download
M shell/context.cc View 1 3 chunks +13 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
Nick Bray (chromium)
Based on top of: https://codereview.chromium.org/868963002/ abarth: reviewer qsr: Android builds clean - but is there ...
5 years, 11 months ago (2015-01-26 21:21:55 UTC) #2
qsr
On 2015/01/26 21:21:55, Nick Bray (chromium) wrote: > Based on top of: https://codereview.chromium.org/868963002/ > abarth: ...
5 years, 11 months ago (2015-01-27 08:53:50 UTC) #3
qsr
About testing -> you can run sky on android (use skydb), or any other app ...
5 years, 11 months ago (2015-01-27 08:54:32 UTC) #4
abarth-chromium
lgtm
5 years, 11 months ago (2015-01-27 18:27:45 UTC) #5
Nick Bray (chromium)
5 years, 10 months ago (2015-01-27 20:55:41 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
863634382256c5ed9046a688aa675287d01ab898 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698