Cache WeakCell for optimized code.

Cache WeakCell for optimized code.

BUG=

Committed: https://crrev.com/a730a31a5bbd6162e2891a40ebceaf2e982f80bf
Cr-Commit-Position: refs/heads/master@{#26274}

[ulan, 2015-01-26 14:32:24]

ulan@chromium.org changed reviewers:
+ yangguo@chromium.org

[ulan, 2015-01-26 14:32:25]

PTAL. I'll use this later in refactoring of dependent code.

[Yang, 2015-01-26 14:55:24]

LGTM

https://codereview.chromium.org/873233002/diff/1/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/873233002/diff/1/src/objects.cc#newcode11039
src/objects.cc:11039: if (raw_cell != NULL) return Handle<WeakCell>(raw_cell);
Suggestion: add an assertion that the cached code is indeed the code we expect.

[ulan, 2015-01-26 15:00:07]

https://codereview.chromium.org/873233002/diff/1/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/873233002/diff/1/src/objects.cc#newcode11039
src/objects.cc:11039: if (raw_cell != NULL) return Handle<WeakCell>(raw_cell);
On 2015/01/26 14:55:23, Yang wrote:
> Suggestion: add an assertion that the cached code is indeed the code we
expect.

Done. Added check in Code::CachedWeakCell

[ulan, 2015-01-26 15:00:13]

The CQ bit was checked by ulan@chromium.org

[commit-bot: I haz the power, 2015-01-26 15:00:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/873233002/20001

[commit-bot: I haz the power, 2015-01-26 15:31:26]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-01-26 15:31:42]

Patchset 2 (id:??) landed as
https://crrev.com/a730a31a5bbd6162e2891a40ebceaf2e982f80bf
Cr-Commit-Position: refs/heads/master@{#26274}