Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 873213002: Clean up release scripts. (Closed)

Created:
5 years, 11 months ago by Michael Achenbach
Modified:
5 years, 11 months ago
Reviewers:
tandrii(chromium)
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Clean up release scripts. This makes some internal renaming, e.g. trunk -> candidates, bleeding edge -> master, without changing the api. Also remove some unused bailout steps from the push script. Remove unused bump version script. BUG=chromium:451975 TBR=tandrii@chromium.org NOTRY=true LOG=n Committed: https://crrev.com/379dcd5bd4f3de23a5ab9107d90182b1bdc2e503 Cr-Commit-Position: refs/heads/master@{#26269}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+146 lines, -542 lines) Patch
M tools/push-to-trunk/auto_push.py View 4 chunks +11 lines, -37 lines 0 comments Download
M tools/push-to-trunk/auto_roll.py View 2 chunks +4 lines, -4 lines 0 comments Download
D tools/push-to-trunk/bump_up_version.py View 1 chunk +0 lines, -247 lines 0 comments Download
M tools/push-to-trunk/chromium_roll.py View 2 chunks +3 lines, -3 lines 0 comments Download
M tools/push-to-trunk/common_includes.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/push-to-trunk/merge_to_branch.py View 9 chunks +13 lines, -13 lines 0 comments Download
M tools/push-to-trunk/push_to_trunk.py View 14 chunks +49 lines, -47 lines 0 comments Download
M tools/push-to-trunk/releases.py View 11 chunks +24 lines, -23 lines 1 comment Download
M tools/push-to-trunk/test_scripts.py View 20 chunks +41 lines, -167 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Michael Achenbach
PTAL
5 years, 11 months ago (2015-01-26 13:23:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/873213002/1
5 years, 11 months ago (2015-01-26 13:29:19 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-26 13:29:31 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/379dcd5bd4f3de23a5ab9107d90182b1bdc2e503 Cr-Commit-Position: refs/heads/master@{#26269}
5 years, 11 months ago (2015-01-26 13:29:40 UTC) #6
tandrii(chromium)
5 years, 11 months ago (2015-01-26 14:31:14 UTC) #7
Message was sent while issue was closed.
Yay, difficult review; relying on coverage more than my eyes.

lgtm

https://codereview.chromium.org/873213002/diff/1/tools/push-to-trunk/releases.py
File tools/push-to-trunk/releases.py (right):

https://codereview.chromium.org/873213002/diff/1/tools/push-to-trunk/releases...
tools/push-to-trunk/releases.py:173: "bleeding_edge": master_position,
i guess, this key can't be changed :(

Powered by Google App Engine
This is Rietveld 408576698