Add AddMessageToDevToolsConsole to WebContentsAndroid

Add AddMessageToDevToolsConsole to WebContentsAndroid

For now there isn't any API to write some logs to dev tools console from
Java layer.
It is required to fix http://crbug.com/426751 .

BUG=426751
Committed: https://crrev.com/7bb2612e8d1b7ef297a85382e5ee0ec0f66d6f8f
Cr-Commit-Position: refs/heads/master@{#313388}

[Jaekyun Seok (inactive), 2015-01-26 03:46:44]

jaekyun@chromium.org changed reviewers:
+ mnaganov@chromium.org, sievers@chromium.org, tedchoc@chromium.org

[Jaekyun Seok (inactive), 2015-01-26 03:46:46]

mnaganov@chromium.org: Please review overall changes.

tedchoc@chromium.org: Please review changes in
content/browser/web_contents/web_contents_android.* and Java layer.

sievers@chromium.org: Please review overall changes in content/.

[mnaganov (inactive), 2015-01-26 14:26:10]

Looks good, except for the method naming.

https://codereview.chromium.org/873133002/diff/1/content/browser/web_contents...
File content/browser/web_contents/web_contents_android.h (right):

https://codereview.chromium.org/873133002/diff/1/content/browser/web_contents...
content/browser/web_contents/web_contents_android.h:107: void
WriteToDevConsole(JNIEnv* env,
"DevConsole" isn't a name that is recognized by everyone. I would suggest naming
this method either "AddMessageToConsole" or "AddMessageToDevToolsConsole".

[Ted C, 2015-01-26 19:23:24]

lgtm w/ mnaganov's approval

[Jaekyun Seok (inactive), 2015-01-26 22:18:47]

PTAL.

I've uploaded a new patch after renaming the method.

https://codereview.chromium.org/873133002/diff/1/content/browser/web_contents...
File content/browser/web_contents/web_contents_android.h (right):

https://codereview.chromium.org/873133002/diff/1/content/browser/web_contents...
content/browser/web_contents/web_contents_android.h:107: void
WriteToDevConsole(JNIEnv* env,
On 2015/01/26 14:26:10, mnaganov (cr) wrote:
> "DevConsole" isn't a name that is recognized by everyone. I would suggest
naming
> this method either "AddMessageToConsole" or "AddMessageToDevToolsConsole".

I will use "AddMessageToDevToolsConsole".

[mnaganov (inactive), 2015-01-27 08:53:11]

lgtm

[no sievers, 2015-01-27 20:01:18]

lgtm

https://codereview.chromium.org/873133002/diff/20001/content/content.gyp
File content/content.gyp (right):

https://codereview.chromium.org/873133002/diff/20001/content/content.gyp#newc...
content/content.gyp:462: 'target_name': 'console_message_level_java',
wow, this is getting cluttered (see all other duplicated blocks below). would be
nice to have something simpler like one rule with a source_header input list. or
even auto-generate the list based on the GENERATED_JAVA_ENUM_PACKAGE annotation
in the C++ header.

https://codereview.chromium.org/873133002/diff/20001/content/public/android/j...
File
content/public/android/java/src/org/chromium/content_public/browser/WebContents.java
(right):

https://codereview.chromium.org/873133002/diff/20001/content/public/android/j...
content/public/android/java/src/org/chromium/content_public/browser/WebContents.java:206:
* Adds a log message to dev tools console. |level| must be a value of
ConsoleMessageLevel.
nit: content_public.common.ConsoleMessageLevel since it's in a different package

[Jaekyun Seok (inactive), 2015-01-27 21:59:11]

https://codereview.chromium.org/873133002/diff/20001/content/content.gyp
File content/content.gyp (right):

https://codereview.chromium.org/873133002/diff/20001/content/content.gyp#newc...
content/content.gyp:462: 'target_name': 'console_message_level_java',
On 2015/01/27 20:01:18, sievers wrote:
> wow, this is getting cluttered (see all other duplicated blocks below). would
be
> nice to have something simpler like one rule with a source_header input list.
or
> even auto-generate the list based on the GENERATED_JAVA_ENUM_PACKAGE
annotation
> in the C++ header.

I filed http://crbug.com/452661 to follow up this request.

https://codereview.chromium.org/873133002/diff/20001/content/public/android/j...
File
content/public/android/java/src/org/chromium/content_public/browser/WebContents.java
(right):

https://codereview.chromium.org/873133002/diff/20001/content/public/android/j...
content/public/android/java/src/org/chromium/content_public/browser/WebContents.java:206:
* Adds a log message to dev tools console. |level| must be a value of
ConsoleMessageLevel.
On 2015/01/27 20:01:18, sievers wrote:
> nit: content_public.common.ConsoleMessageLevel since it's in a different
package

Done.

[Jaekyun Seok (inactive), 2015-01-27 22:01:12]

The CQ bit was checked by jaekyun@chromium.org

[commit-bot: I haz the power, 2015-01-27 22:01:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/873133002/40001

[commit-bot: I haz the power, 2015-01-27 22:53:30]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-01-27 22:54:36]

Patchset 3 (id:??) landed as
https://crrev.com/7bb2612e8d1b7ef297a85382e5ee0ec0f66d6f8f
Cr-Commit-Position: refs/heads/master@{#313388}