Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Issue 873083002: components: Cleanup and sort components_unittests deps list. (Closed)

Created:
5 years, 11 months ago by tfarina
Modified:
5 years, 10 months ago
Reviewers:
blundell
CC:
chromium-reviews, jochen (gone - plz use gerrit)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

components: Cleanup and sort components_unittests deps list. BUG=None TEST=components_unittests R=blundell@chromium.org Committed: https://crrev.com/7d49066df1b731730a134db2757a5d8f549f05fc Cr-Commit-Position: refs/heads/master@{#313077}

Patch Set 1 #

Total comments: 1

Patch Set 2 : more #

Patch Set 3 : revert the other deps lists changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -114 lines) Patch
M components/components_tests.gyp View 2 1 chunk +16 lines, -114 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
tfarina
https://codereview.chromium.org/873083002/diff/1/components/components_tests.gyp File components/components_tests.gyp (left): https://codereview.chromium.org/873083002/diff/1/components/components_tests.gyp#oldcode332 components/components_tests.gyp:332: # Dependencies of auto_login_parser These comments were driving me ...
5 years, 11 months ago (2015-01-25 17:03:54 UTC) #1
blundell
Do you mind splitting this up and doing one list of dependencies at a time? ...
5 years, 10 months ago (2015-01-26 09:24:36 UTC) #2
tfarina
Done. I removed the other changes. Should be fine now. I will do them separately.
5 years, 10 months ago (2015-01-26 15:14:49 UTC) #3
blundell
lgtm
5 years, 10 months ago (2015-01-26 15:45:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/873083002/40001
5 years, 10 months ago (2015-01-26 16:03:45 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-01-26 16:22:16 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-01-26 16:22:55 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/7d49066df1b731730a134db2757a5d8f549f05fc
Cr-Commit-Position: refs/heads/master@{#313077}

Powered by Google App Engine
This is Rietveld 408576698